security icon indicating copy to clipboard operation
security copied to clipboard

Migrate from com.amazon.dlic to org.opensearch.security package

Open shikharj05 opened this issue 9 months ago • 1 comments

Description

  • Category (Enhancement, New feature, Bug fix, Test fix, Refactoring, Maintenance, Documentation) Refactoring
  • Why these changes are required? The classes were originally part of https://github.com/opendistro-for-elasticsearch/deprecated-security-advanced-modules and not moved to org.opensearch.security when opensearch security was bootstrapped; moving them now.
  • What is the old behavior before changes and new behavior after changes? No behavior change

Issues Resolved

Is this a backport? If so, please add backport PR # and/or commits #, and remove backport-failed label from the original PR.

Do these changes introduce new permission(s) to be displayed in the static dropdown on the front-end? If so, please open a draft PR in the security dashboards plugin and link the draft PR here

Testing

[Please provide details of testing done: unit testing, integration testing and manual testing]

Check List

  • [NA] New functionality includes testing
  • [NA] New functionality has been documented
  • [NA] New Roles/Permissions have a corresponding security dashboards plugin PR
  • [NA] API changes companion pull request created
  • [X] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. For more information on following Developer Certificate of Origin and signing off your commits, please check here.

shikharj05 avatar Mar 28 '25 05:03 shikharj05

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 71.72%. Comparing base (fc2e5fc) to head (cdddd04). Report is 6 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #5223      +/-   ##
==========================================
+ Coverage   71.65%   71.72%   +0.07%     
==========================================
  Files         335      335              
  Lines       22742    22740       -2     
  Branches     3597     3597              
==========================================
+ Hits        16295    16310      +15     
+ Misses       4653     4637      -16     
+ Partials     1794     1793       -1     
Files with missing lines Coverage Δ
.../main/java/com/amazon/dlic/auth/ldap/LdapUser.java 89.28% <ø> (ø)
.../org/opensearch/security/auth/BackendRegistry.java 77.77% <ø> (ø)
...ty/auth/http/jwt/AbstractHTTPJwtAuthenticator.java 60.43% <ø> (ø)
...h/security/auth/http/jwt/HTTPJwtAuthenticator.java 80.32% <ø> (ø)
...t/keybyoidc/AuthenticatorUnavailableException.java 40.00% <ø> (ø)
...th/http/jwt/keybyoidc/BadCredentialsException.java 40.00% <ø> (ø)
...byoidc/HTTPJwtKeyByOpenIdConnectAuthenticator.java 91.66% <ø> (ø)
.../security/auth/http/jwt/keybyoidc/JwtVerifier.java 80.00% <ø> (ø)
...urity/auth/http/jwt/keybyoidc/KeySetRetriever.java 79.04% <ø> (ø)
.../auth/http/jwt/keybyoidc/SelfRefreshingKeySet.java 65.49% <ø> (ø)
... and 25 more

... and 7 files with indirect coverage changes

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

codecov[bot] avatar Mar 28 '25 07:03 codecov[bot]