security icon indicating copy to clipboard operation
security copied to clipboard

fix build errors caused by filterIndices method being moved from SnapshotUtils to IndexUtils

Open dancristiancecoi opened this issue 1 year ago • 6 comments

Description

This PR fixes build errors caused by a recent change in Core where the filderIndices() method got moved from SnapshotUtils to IndexUtils

Issues Resolved

#4312

Check List

  • [ ] New functionality includes testing
  • [ ] New functionality has been documented
  • [x] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. For more information on following Developer Certificate of Origin and signing off your commits, please check here.

dancristiancecoi avatar May 03 '24 15:05 dancristiancecoi

Thanks @dancristiancecoi for raising this fix. Could you point to the change that caused this?

Sure! The PR: https://github.com/opensearch-project/OpenSearch/pull/8922/commits The actual commit: https://github.com/opensearch-project/OpenSearch/pull/8922/commits/1304ef3b26a5e1f60e5d77ea6cef12f0d765c040

dancristiancecoi avatar May 03 '24 16:05 dancristiancecoi

Thanks @dancristiancecoi. The changes seems in-line with the changes in core. Would you please look at backwards-compatibility failures?

DarshitChanpura avatar May 03 '24 16:05 DarshitChanpura

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 66.07%. Comparing base (6d35a0a) to head (474e40f). Report is 3 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4313      +/-   ##
==========================================
- Coverage   66.12%   66.07%   -0.06%     
==========================================
  Files         302      302              
  Lines       21758    21758              
  Branches     3522     3522              
==========================================
- Hits        14387    14376      -11     
- Misses       5609     5614       +5     
- Partials     1762     1768       +6     
Files Coverage Δ
...earch/security/resolver/IndexResolverReplacer.java 68.01% <100.00%> (ø)
...search/security/support/SnapshotRestoreHelper.java 82.75% <100.00%> (ø)

... and 8 files with indirect coverage changes

codecov[bot] avatar May 03 '24 16:05 codecov[bot]

This change needs to go into 2.x first to resolve the bwc test failures. 2.x isn't compiling along with main since this change was recently backported to 2.x in core.

cwperks avatar May 03 '24 16:05 cwperks

Thank you for the contribution @dancristiancecoi! The changes look good to me.

cwperks avatar May 03 '24 16:05 cwperks

Created a backport for this change to 2.x. Once that's merged the bwc checks can be re-run on this PR: https://github.com/opensearch-project/security/pull/4319

cwperks avatar May 05 '24 22:05 cwperks

Created a backport for this change to 2.x. Once that's merged the bwc checks can be re-run on this PR: #4319

Thank you, @cwperks. I merged it.

willyborankin avatar May 06 '24 11:05 willyborankin

Thank you @willyborankin ! Looks like the bwc checks are green now. Merging this PR.

cwperks avatar May 06 '24 11:05 cwperks