security-dashboards-plugin icon indicating copy to clipboard operation
security-dashboards-plugin copied to clipboard

Published 20 hours ago • verified publisher icon opensearch-project

[FEATURE] Refactor Request Type interface to be more clear

Open derek-ho opened this issue 1 year ago • 1 comments
trafficstars

Is your feature request related to a problem? With the introduction of multiple datasources feature, two new interfaces were introduced: RequestParams and RequestTypeParams. During PR review there was confusion about these two types: https://github.com/opensearch-project/security-dashboards-plugin/pull/1888#discussion_r1569283444. This issue is as a placeholder to fast follow up around the naming and see if there is a way to consolidate these two to avoid confusion

What solution would you like? Consolidation of the two interfaces and/or removal of the general method

What alternatives have you considered? None Do you have any additional context? None

derek-ho avatar Apr 25 '24 15:04 derek-ho

[Triage] Hi @derek-ho thank you for filing this issue. This looks like a follow-up issue. I will leave without the label until you add your follow-up.

stephen-crawford avatar Apr 29 '24 15:04 stephen-crawford

This is no longer applicable as part of the PR merged we refactored it to go through another class

derek-ho avatar May 06 '24 15:05 derek-ho