security-dashboards-plugin
security-dashboards-plugin copied to clipboard
opensearch-project
[FEATURE] Add check for both workspace and multi tenancy enabled
Is your feature request related to a problem?
The workspace feature will have similar functionality with multi tenancy. If they are both turned on that may confuse user, as there have two ways to separated data.
What solution would you like?
Add a check in security dashboard plugin to check if workspace plugin is turned on and multi tenancy is on, then OSD will exit and print out an error message when startup.
The reason why not add this check in workspace plugin are
- Workspace can't depends on security dashboard plugin as the code are sit in OSD repo
- No way for workspace plugin read the config of security dashboard plugin, as plugins are not allowed to read config of other plugins.
What alternatives have you considered?
Do you have any additional context? https://github.com/opensearch-project/OpenSearch-Dashboards/issues/4944
The workspace feature will have similar functionality with multi tenancy. If they are both turned on that may confuse user, as there have two ways to separated data.
@Hailong-am could you please describe the scenarios that will be confusing? For customers that are already using multi tenancy this will also be confusion. I suspect the UX will need changes to help mitigate this confusion, what do you think?
could you please describe the scenarios that will be confusing?
If a user create a few different workspaces with dashboards, those dashboards will be isolated by workspace. They can switch between workspaces like switch tenancy. However, with workspace mixed with tenancy, user need to pay attention to two things, workspace and tenancy. A user create a workspace and that will store in .kibana index by default, then it switch to another tenancy, all those data are missing. they may wonder where is my workspace.
For customers that are already using multi tenancy this will also be confusion.
If they want to give a try to workspace, they could turn off mutli tenancy for a while and change it back when finshed.
I suspect the UX will need changes to help mitigate this confusion, what do you think?
Yes, that will have tenancy migration guide when start to use workspace at the first time.
[Triage] Hi @Hailong-am thanks for filing this issue. This seems like we can move forward with the change you suggested. I will also go ahead and assign this to you like you asked.
