security-dashboards-plugin icon indicating copy to clipboard operation
security-dashboards-plugin copied to clipboard

[BUG] Roles/Security/<RoleName> Index permissions view abbreviated with no way to expand

Open einhirn opened this issue 2 years ago • 1 comments

What is the bug? In the Roles/Security/<RoleName> view on the permissions tab, there are only three index patterns shown for each entry in the index permissions view. The list is abbreviated with no way to expand.

How can one reproduce the bug? Steps to reproduce the behavior:

  1. create a role with more than 3 index patterns
  2. view the role
  3. the list is truncated with no way to expand

What is the expected behavior? I understand why the list is truncated by default, but there should be a way to expand the list without needing to "Edit" the role - what if you don't have the right to edit a role and still need to know which index_patterns it applies permissions to?

The list should be expandable somehow, either when expanding the row itself or when clicking the three dots showing the truncation.

What is your host/environment?

  • OS: Ubuntu 22.04
  • Opensearch Dashboards Version v1.3.4
  • Plugins (Can't find a separate Version number for the security plugin)

Do you have any screenshots? Screenshot of Roles permissions view, a truncated item in the "Index" column of the Index permissions panel highlighted

Do you have any additional context? https://github.com/opensearch-project/security-dashboards-plugin/blob/bea778f73b76cb5bd4e17d25f994409590c4fac9/public/apps/configuration/utils/display-utils.tsx#L79 is used to render the truncated list in https://github.com/opensearch-project/security-dashboards-plugin/blob/bea778f73b76cb5bd4e17d25f994409590c4fac9/public/apps/configuration/panels/role-view/index-permission-panel.tsx#L133 and neighboring lines. Maybe https://github.com/opensearch-project/security-dashboards-plugin/blob/bea778f73b76cb5bd4e17d25f994409590c4fac9/public/apps/configuration/panels/role-view/index-permission-panel.tsx#L45 could be used to render a non-truncated list when the row is expanded?

einhirn avatar Jan 16 '23 09:01 einhirn

[Triage] @shanilpa could you please follow-up on some improvements for this. Thank you.

stephen-crawford avatar Jan 17 '23 20:01 stephen-crawford