search-processor
search-processor copied to clipboard
[Build] Jackson-core as a dependency
Context
https://github.com/opensearch-project/search-processor/pull/132
Some GitHub action backend code using jackson-core 2.5.0 is failing builds because it includes an MRJAR with JDK 19 code. See, for example, this failed action.
Action items
- [x] For the short term, upgrade to jackson-core 2.5.0 in main branch to resolve the build failure. Also upgrade gradle https://github.com/opensearch-project/search-processor/pull/132 - Resolved here https://github.com/opensearch-project/search-processor/pull/134
- [ ] For the long term, we must devise a sustainable decision on
Jackson-coreas a dependency ref to Dan's suggestions here. Can we remove alljackson-packages? if not. we need test on build and integration. [Non urgent] - [ ] Check if the current dependabot is working well, or examine alternatives.
Some observations:
- OpenSearch main branch is using jackson-core 2.5.0 https://github.com/opensearch-project/OpenSearch/tree/main/client/sniffer/licenses
- Security plugin removed jackson-databind and jackson-annotations https://github.com/opensearch-project/security/pull/2325
- Observability plugin removed jackson depenencies and then added them back https://github.com/opensearch-project/observability/pull/1379
Since we currently have build failures, we are opting to upgrade jackson-core to 2.5.0 for now, as implemented in #134. Alternatives are continued to be looked at.
What's the latest on this? Should this be closed and a new issue created for long term?