search-processor icon indicating copy to clipboard operation
search-processor copied to clipboard

[Build] Jackson-core as a dependency

Open noCharger opened this issue 2 years ago • 2 comments

Context

https://github.com/opensearch-project/search-processor/pull/132

Some GitHub action backend code using jackson-core 2.5.0 is failing builds because it includes an MRJAR with JDK 19 code. See, for example, this failed action.

Action items

  • [x] For the short term, upgrade to jackson-core 2.5.0 in main branch to resolve the build failure. Also upgrade gradle https://github.com/opensearch-project/search-processor/pull/132 - Resolved here https://github.com/opensearch-project/search-processor/pull/134
  • [ ] For the long term, we must devise a sustainable decision on Jackson-core as a dependency ref to Dan's suggestions here. Can we remove all jackson- packages? if not. we need test on build and integration. [Non urgent]
  • [ ] Check if the current dependabot is working well, or examine alternatives.

Some observations:

  1. OpenSearch main branch is using jackson-core 2.5.0 https://github.com/opensearch-project/OpenSearch/tree/main/client/sniffer/licenses
  2. Security plugin removed jackson-databind and jackson-annotations https://github.com/opensearch-project/security/pull/2325
  3. Observability plugin removed jackson depenencies and then added them back https://github.com/opensearch-project/observability/pull/1379

noCharger avatar Apr 28 '23 18:04 noCharger

Since we currently have build failures, we are opting to upgrade jackson-core to 2.5.0 for now, as implemented in #134. Alternatives are continued to be looked at.

sejli avatar May 02 '23 00:05 sejli

What's the latest on this? Should this be closed and a new issue created for long term?

macohen avatar Jun 13 '23 15:06 macohen