project-website
project-website copied to clipboard
add blog for develop guide on how multiple data source to integrate w…
Description
add blog for develop guide on how multiple data source to integrate with dashboards plugin
Issues Resolved
- https://github.com/opensearch-project/project-website/issues/2815
- https://app.asana.com/0/0/1207209331528869/f
Check List
- [ ] Commits are signed per the DCO using --signoff
By submitting this pull request, I confirm that my contribution is made under the terms of the BSD-3-Clause License.
Thanks @zhyuanqi
@kavilla @BionIT @zengyan-amazon would you help to review
Looks great ! Couple comments but really just nitpicks. But I don't have the best grammar skills.
General nitpicks:
- I noticed it switches between "multiple data source" and "multiple data sources" it think the latter sounds better.
- It switched between "Dashboards" and "dashboards" . The uppercase makes more sense to me in this context because when referencing other plugins I see you are lower casing them.
- Developers can also configure this to start without modifying the yaml file by starting it up with
data_source.enabled=true
. Since MDS is also a core osd feature we could potentially add a new script in the package.json file likeyarn start:mds
which essentially just calls start but with data source enabled.Coupling that with my comment about updating the cli for generating a plugin then could be really easy for developers to get this.
Awesome though. 😎
Thanks. Let me change to "multiple data sources" and "Dashboards"
Per @brijos, he will work with the appropriate technical writer to revise the draft (as necessary) and then send for a second editorial review.
Per @brijos, he will work with the appropriate technical writer to revise the draft (as necessary) and then send for a second editorial review.
Hi @natebower is there any update. could we are able to close this this week?
I can have a tech writer review it. In the meantime, @zhyuanqi, can you address the style errors? Thanks!
@zhyuanqi It looks like there are still comments/suggestions in this PR that will need to be resolved before this can be moved forward in the process. Just wanted to call your attention to it so that this doesn't fall through the cracks 😄.
@zhyuanqi It looks like there are still comments/suggestions in this PR that will need to be resolved before this can be moved forward in the process. Just wanted to call your attention to it so that this doesn't fall through the cracks 😄.
Okay, Let me check on it.
@natebower I should have applied all the comments in the newest commit. Could you help to check if anything missing
@natebower I should have applied all the comments in the newest commit. Could you help to check if anything missing
@zhyuanqi It looks like there is just one comment outstanding on line 310, but otherwise, LGTM.
@pajuric Confirmed that all other comments/suggestions appear to have been addressed and that this should be good to go once the remaining one is resolved. Thanks!
@natebower I should have applied all the comments in the newest commit. Could you help to check if anything missing
@zhyuanqi It looks like there is just one comment outstanding on line 310, but otherwise, LGTM.
@pajuric Confirmed that all other comments/suggestions appear to have been addressed and that this should be good to go once the remaining one is resolved. Thanks!
I have addressed the comment on line 310. Thanks for checking on my doc
@nateynateynate @krisfreedain - Blog is ready to publish tomorrow - Tuesday, June 4. Thanks.