project-website icon indicating copy to clipboard operation
project-website copied to clipboard

Improve detection of Time-Zone inconsistencies

Open smortex opened this issue 2 years ago • 2 comments

We have a track record of Time-Zone inconsistencies in the events of the project website (e.g. #1616, #1805, #2288, #2418, #2422, #2431, #2449).

In order to detect these inconsistencies earlier, make the tz mandatory and check that the Time-Zone offset match the Time-Zone name. These checks require a working bundle so run it on GitHub actions and keep the old pre-commit check to only check date formatting using basic UNIX tooling.

Adjust the events templates to match what we expect.

While here, also check that non-online events have the needed location.city and location.country.

smortex avatar Nov 28 '23 07:11 smortex

This will hopefully avoid more work for @krisfreedain and @nateynateynate to review and merge my PRs to fix Time-Zone issues :sweat_smile:

Cc @joshuarrrr who also hit some Time-Zone related issue.

I tried to split each part in a separate commit to make it easier to follow the fix process. As a bonus, we can see that the check script report less and less failures as we go.

Thanks!

smortex avatar Nov 28 '23 08:11 smortex

WOW! Thank you @smortex!!

@astephanus - could you give this a look?

krisfreedain avatar Nov 29 '23 21:11 krisfreedain