performance-analyzer icon indicating copy to clipboard operation
performance-analyzer copied to clipboard

Draft PR for changes related to PA RTF merging

Open atharvasharma61 opened this issue 10 months ago • 2 comments

Is your feature request related to a problem? Please provide an existing Issue # , or describe. A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]

Describe the solution you are proposing A clear and concise description of what you want to happen.

Describe alternatives you've considered A clear and concise description of any alternative solutions or features you've considered.

Additional context Add any other context or screenshots about the feature request here.

Check List

  • [ ] Backport Labels added.
  • [ ] New functionality includes testing.
    • [ ] All tests pass
  • [ ] New functionality has been documented.
    • [ ] New functionality has javadoc added
  • [ ] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. For more information on following Developer Certificate of Origin and signing off your commits, please check here.

atharvasharma61 avatar Apr 25 '24 13:04 atharvasharma61

https://pastecode.io/s/9bksb3ak Heap metrics

atharvasharma61 avatar Apr 25 '24 13:04 atharvasharma61

Hi @atharvasharma61! This looks like an interesting change, do we have any rfc/doc to provide more context?

ansjcy avatar Apr 25 '24 21:04 ansjcy

Overall looks good, please address the open comments and build failures.

Gaganjuneja avatar Jun 05 '24 00:06 Gaganjuneja

I am hoping there are changes in performance-analyzer-commons package also in class ScheduledMetricCollectorsExecutor. Please attache that PR also here.

Gaganjuneja avatar Jun 05 '24 00:06 Gaganjuneja

One more thing to call-out: We need to enable delta temporality in Opensearch Otel. @Gaganjuneja

atharvasharma61 avatar Jun 05 '24 08:06 atharvasharma61

Please take a look at build failures.

Gaganjuneja avatar Jun 06 '24 05:06 Gaganjuneja

Please take a look at build failures.

Dependent on PRs: https://github.com/opensearch-project/performance-analyzer/pull/657 and https://github.com/opensearch-project/performance-analyzer-commons/pull/74

atharvasharma61 avatar Jun 06 '24 06:06 atharvasharma61

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.x 2.x
# Navigate to the new working tree
cd .worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-651-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 17611035b0519b96de809da2ccb07ea9b4107ede
# Push it to GitHub
git push --set-upstream origin backport/backport-651-to-2.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-651-to-2.x.