performance-analyzer icon indicating copy to clipboard operation
performance-analyzer copied to clipboard

Ensure that PATransportChannel delegates to wrapped channel and add tests

Open cwperks opened this issue 1 year ago • 4 comments

Is your feature request related to a problem? Please provide an existing Issue # , or describe.

Ensures that PATransportChannel delegates implementations to the wrapped channel except for:

  • getChannelType
  • getProfileName

Added tests that use reflection to ensure that if the TransportChannel interface changes that the CI in this repo catches it to ensure that this wrapper class gets modified accordingly.

Additional context

https://github.com/opensearch-project/performance-analyzer/issues/606

Check List

  • [ ] Backport Labels added.
  • [ ] New functionality includes testing.
    • [ ] All tests pass
  • [ ] New functionality has been documented.
    • [ ] New functionality has javadoc added
  • [ ] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. For more information on following Developer Certificate of Origin and signing off your commits, please check here.

cwperks avatar Dec 07 '23 16:12 cwperks

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 69.37%. Comparing base (9cb092f) to head (e5bfb28). Report is 1 commits behind head on main.

:exclamation: Current head e5bfb28 differs from pull request most recent head c9edae1

Please upload reports for the commit c9edae1 to get more accurate results.

Additional details and impacted files
@@             Coverage Diff              @@
##               main     #609      +/-   ##
============================================
- Coverage     70.88%   69.37%   -1.51%     
+ Complexity      421      374      -47     
============================================
  Files            49       44       -5     
  Lines          3125     2691     -434     
  Branches        194      172      -22     
============================================
- Hits           2215     1867     -348     
+ Misses          785      721      -64     
+ Partials        125      103      -22     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Dec 07 '23 16:12 codecov[bot]

The BWC tests are failing, can you bump up the BWC version to 2.11 here: https://github.com/opensearch-project/performance-analyzer/blob/main/build.gradle#L13. The same needs to be back-ported to 2.x branch.

khushbr avatar Dec 08 '23 05:12 khushbr

@cwperks want to finish this?

dblock avatar Jun 06 '24 15:06 dblock

Rebased with main. @Gaganjuneja @psychbot Can you take a look?

cwperks avatar Jun 25 '24 20:06 cwperks