oui icon indicating copy to clipboard operation
oui copied to clipboard

Fix version selector for parity with previous version

Open BSFishy opened this issue 1 year ago • 2 comments

Description

The current version selector navigates to <url>/<version> instead of <url>/<version>/. The trailing / is necessary to navigate to the correct version. Currently, if you try navigating to a different version on https://oui.opensearch.org/1.4/, it won't change the version.

Additionally, I made a change to the way the response promise is handled to properly handle case where there is an error with the fetch.

I think a change was made to the CDK to fix this as well, but I wanted to keep parity with the previous version of the version selector

Check List

  • [ ] New functionality includes testing.
  • [ ] New functionality has been documented.
  • [x] All tests pass
    • [x] yarn lint
    • [x] yarn test-unit
  • [ ] Update CHANGELOG.md
  • [x] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

For more information on following Developer Certificate of Origin and signing off your commits, please check here.

BSFishy avatar Jan 11 '24 17:01 BSFishy