opensearch-sdk-java icon indicating copy to clipboard operation
opensearch-sdk-java copied to clipboard

[FEATURE] Add monitoring support for extensions

Open saratvemulapalli opened this issue 2 years ago • 9 comments

Is your feature request related to a problem?

Plugins are embedded into OpenSearch process which prevents easy monitoring. With extensions I would love to see monitoring support which helps in a. Tracking Performance b. Tracking the progress of extension.

What solution would you like?

A simple way to measure events within the extension system and a framework to publish metrics. This is intended to be generic and we could discuss the major event types we'd like to categorize. Few thoughts (but not limited to):

  • Requests to/from all extension points (helps measure against performance of plugins)
  • Extension health stats like CPU, heap etc

saratvemulapalli avatar Feb 28 '23 20:02 saratvemulapalli

Hi @saratvemulapalli , @dbwiddis

Can I work on this ( if others are not planning to take this ) after I finish the current one ?

Thanks.

varuntumbe avatar Mar 01 '23 08:03 varuntumbe

Thanks @varuntumbe absolutely. There are lot more details involved including design, I would be glad to work with you to untangle the problem.

saratvemulapalli avatar Mar 01 '23 18:03 saratvemulapalli

Great ! @saratvemulapalli , I have got a little bit of rebasing problem going on with the current one. I will reach out to you within this week ( tomorrow or day after tomorrow ) after the completion of the current one.

Thanks.

varuntumbe avatar Mar 01 '23 19:03 varuntumbe

Hi @saratvemulapalli @dbwiddis ,

I will be free for few hours during weekend. You want me to look at any code in specific ?

Thanks and regards Varun

varuntumbe avatar Mar 03 '23 20:03 varuntumbe

Hi @saratvemulapalli ,

I will try to write one test class for initializeExtensionRequest until we finalize on the design part of this feature.

Thanks and Regards Varun

varuntumbe avatar Mar 08 '23 19:03 varuntumbe

Thanks @varuntumbe for picking this up. I've added discuss label, few of the requirements are added in here.

Requests to/from all extension points (helps measure against performance of plugins)

I think you can start with exploring ideas of publishing metrics for each request, we use netty underneath. Do you want to take a stab at exploring opensource solutions we could use ?

saratvemulapalli avatar Mar 13 '23 18:03 saratvemulapalli

Hi @saratvemulapalli ,

Sure let me see what I can find. Basically first thing is to track and publish the metric ( in this case requests to and from extension points ). I might have some doubts on the specificity of this feature, i will post a question as and when I get it, if it's okay.

Thanks and regards Varun

varuntumbe avatar Mar 14 '23 15:03 varuntumbe

@varuntumbe absolutely!!

saratvemulapalli avatar Mar 14 '23 17:03 saratvemulapalli

Hi @saratvemulapalli

I will spend some time after closing the current bug and will let you know soon

Thanks

varuntumbe avatar Mar 26 '23 19:03 varuntumbe