opensearch-ruby icon indicating copy to clipboard operation
opensearch-ruby copied to clipboard

Published 20 hours ago • verified publisher icon opensearch-project

[BUG] Don't modify incoming hash parameters

Open dblock opened this issue 1 year ago • 0 comments

What is the bug?

Coming from https://github.com/opensearch-project/opensearch-ruby/pull/155#discussion_r1145305950 replace all modifying of incoming hashes by duping them. See https://code.dblock.org/2020/11/11/dup-dont-modify-input-hash-parameters-in-ruby.html for some horror stories.

What is the expected behavior?

Do not modify hashes. Add tests.

dblock avatar Mar 23 '23 17:03 dblock