opensearch-plugins icon indicating copy to clipboard operation
opensearch-plugins copied to clipboard

[PROPOSAL] Replace direct plugin download by maven dependencies for bcw

Open dblock opened this issue 3 years ago • 1 comments

What/Why

What are you proposing?

Coming from https://github.com/opensearch-project/cross-cluster-replication/pull/566#issuecomment-1262653097, replace any direct download of the latest plugin zip such as https://github.com/opensearch-project/job-scheduler/pull/242 by a maven dependency.

Document how to do this in https://github.com/opensearch-project/opensearch-plugins/blob/main/TESTING.md#backwards-compatibility-testing

What users have asked for this feature?

See https://github.com/opensearch-project/cross-cluster-replication/pull/566#issuecomment-1262653097. This would reduce the amount of code needed for bcw.

What problems are you trying to solve?

Standardize dependency management for bcw across plugins.

dblock avatar Oct 04 '22 13:10 dblock

before this is done in the other repositories, https://github.com/opensearch-project/OpenSearch/issues/4589 should be solved so that the code can be further simplified. the current hack with RegularFile creates a lot of unnecessary overhead and goes directly against what the javadoc of RegularFile says (i.e.: never construct it yourself).

rursprung avatar Oct 06 '22 07:10 rursprung