opensearch-php icon indicating copy to clipboard operation
opensearch-php copied to clipboard

[FEATURE] Remove includePortInHostHeader

Open dblock opened this issue 2 years ago • 1 comments

Is your feature request related to a problem?

The library has a client builder option includePortInHostHeader. This seems unnecessary. Why do we need an option at all? Can we replace it with the solution below of automatically including the port number unless it's a default port?

What solution would you like?

A port should always be included if it's not the default one (HTTP = 80, HTTPS = 443).

Do you have any additional context?

Coming from https://github.com/opensearch-project/opensearch-php/pull/118

dblock avatar Feb 09 '23 13:02 dblock

Hello @joanna-bak-sourceability, I hope you're doing well. If you have a moment to spare, would you be open to considering taking up this issue? Thank you.

saimedhi avatar May 23 '24 08:05 saimedhi