opensearch-migrations icon indicating copy to clipboard operation
opensearch-migrations copied to clipboard

Published 20 hours ago • verified publisher icon opensearch-project

Rfs instrumentation

Open gregschohn opened this issue 9 months ago • 1 comments

Description

Instruments RestClient within RFS so that every call has a context. I'm not currently filling the context in with any

  • Category New feature/Refactoring/OE
  • Why these changes are required? To get better observability into RFS
  • What is the old behavior before changes and new behavior after changes? Now HTTP calls in RFS emit spans and metrics.

Issues Resolved

https://opensearch.atlassian.net/browse/MIGRATIONS-1738

Is this a backport? If so, please add backport PR # and/or commits #

Testing

Limited manual testing. RFS doesn't have much test infrastructure yet

Check List

  • [x] New functionality includes testing
    • [ ] All tests pass, including unit test, integration test and doctest
  • [ ] New functionality has been documented
  • [x] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. For more information on following Developer Certificate of Origin and signing off your commits, please check here.

gregschohn avatar May 23 '24 04:05 gregschohn