opensearch-js icon indicating copy to clipboard operation
opensearch-js copied to clipboard

[FEATURE] plans to support rollup & transform APIs?

Open djmadeira opened this issue 10 months ago • 4 comments

Is your feature request related to a problem?

JS client does not support rollup and transform features of OS

What solution would you like?

Add support to programmatically control rollup and transform features

djmadeira avatar Apr 01 '24 20:04 djmadeira

Yes, please contribute specs to https://github.com/opensearch-project/opensearch-api-specification (mind https://github.com/opensearch-project/opensearch-api-specification/pull/208 that is switching to OpenAPI), the clients are generated from there.

dblock avatar Apr 01 '24 20:04 dblock

Trying to get these specs typed up, @dblock can you point me to the source code where rollups are implemented? The docs page isn't nearly complete enough for me to work out what all the possible values are.

djmadeira avatar Apr 16 '24 21:04 djmadeira

I think it's in ISM

dblock avatar Apr 16 '24 21:04 dblock

Added specs for rollups and transforms

djmadeira avatar May 22 '24 14:05 djmadeira

The generator for this client is still its infancy but I can try and generate some of it and edit it manually

nhtruong avatar Jun 05 '24 17:06 nhtruong

@nhtruong any idea when we can expect these? Is this a relatively simple change?

djmadeira avatar Jun 10 '24 16:06 djmadeira

I'm aiming to have these merged and deployed by the end of the week. I can generate these methods now. Need to iron out the edge cases and then manually insert these methods into the API. Will keep you posted on the progress through out the week.

nhtruong avatar Jun 10 '24 16:06 nhtruong

Here's the draft. Please take a look. Still need to add some basic typing so the IDEs can autocomplete for these added functions. (Full typing will come later)

nhtruong avatar Jun 11 '24 20:06 nhtruong

@djmadeira PR is ready for review

nhtruong avatar Jun 12 '24 16:06 nhtruong

It will be part of 2.10.0 that will be released later today: https://github.com/opensearch-project/opensearch-js/pull/798

nhtruong avatar Jun 13 '24 17:06 nhtruong

2.10.0 has been published

nhtruong avatar Jun 13 '24 20:06 nhtruong