opensearch-js
opensearch-js copied to clipboard
Refactor BaseConnectionPool empty method
Description
ConnectionPool.empty() never calls callback when there is no connection. Refactor empty method so that callback will get always called.
Issues Resolved
List any issues this PR will resolve, e.g. Closes [...].
Check List
- [X] New functionality includes testing.
- [X] All tests pass
- [X] Linter check was successfull -
yarn run lint
doesn't show any errors - [X] Commits are signed per the DCO using --signoff
- [X] Changelog was updated.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. For more information on following Developer Certificate of Origin and signing off your commits, please check here.
Looks good, needs a test please.
Looks good, needs a test please.
Added UT with no connection.