opensearch-js icon indicating copy to clipboard operation
opensearch-js copied to clipboard

Refactor BaseConnectionPool empty method

Open bandinib-amzn opened this issue 1 year ago • 2 comments

Description

ConnectionPool.empty() never calls callback when there is no connection. Refactor empty method so that callback will get always called.

Issues Resolved

List any issues this PR will resolve, e.g. Closes [...].

Check List

  • [X] New functionality includes testing.
    • [X] All tests pass
  • [X] Linter check was successfull - yarn run lint doesn't show any errors
  • [X] Commits are signed per the DCO using --signoff
  • [X] Changelog was updated.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. For more information on following Developer Certificate of Origin and signing off your commits, please check here.

bandinib-amzn avatar Aug 12 '23 01:08 bandinib-amzn

Looks good, needs a test please.

dblock avatar Aug 14 '23 15:08 dblock

Looks good, needs a test please.

Added UT with no connection.

bandinib-amzn avatar Aug 14 '23 23:08 bandinib-amzn