opensearch-java icon indicating copy to clipboard operation
opensearch-java copied to clipboard

Add similarity settings when using CreateIndexRequest

Open ritty27 opened this issue 1 year ago • 1 comments

Description

This PR Partial resolution https://github.com/opensearch-project/opensearch-java/issues/987 There are several types of Similarity, so I only made some of the representative ones (BM25, Boolean). Therefore, the code does not implement all similarity(DFI, DFR, IB etc.). If the this commit is okay, I will try to implement other types similarly.

Issues Resolved

#987

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. For more information on following Developer Certificate of Origin and signing off your commits, please check here.

ritty27 avatar May 16 '24 03:05 ritty27

Looks good to me, needs tests, documentation, samples, etc.

Take a look at https://github.com/opensearch-project/opensearch-api-specification too. I think we want to derive a lot of this code from spec (@Xtansia is working on a generator #366).

dblock avatar May 16 '24 12:05 dblock

An iteration of index settings similarity was generated and released as part of v3.0.0. Any future changes/fixes should be addressed in the https://github.com/opensearch-project/opensearch-api-specification

Xtansia avatar May 18 '25 23:05 Xtansia