opensearch-build icon indicating copy to clipboard operation
opensearch-build copied to clipboard

[Plugins CI] Generate 1.4.0 artifact to unblock CIs

Open DarshitChanpura opened this issue 1 year ago • 5 comments

Security-dashboards-plugin CI for 1.x branch is currently blocked due to security plugin 1.4.0.0 artifact not being available[1]. All security-dashboards plugin PRs currently pointing to 1.x branch are blocked.

I understand that the 1.3 is the last minor version in 1.x line and there will not be 1.4.0 however OpenSearch and OpenSearch Dashboards seems to already been incremented to 1.4.0. So this is request to publish 1.4.0 artifact to unblock merging changes in 1.x line to then be backported to 1.3.

If we think that is not the best solution, an alternative approach is to announce it to plugins to stop basing PRs against 1.x, and directly push the changes to 1.3 which will unblock changes going into 1.3.

Thoughts?

[1] - https://github.com/opensearch-project/security-dashboards-plugin/pull/1750

DarshitChanpura avatar Jan 31 '24 19:01 DarshitChanpura

[Triage] Hey @DarshitChanpura I have added 1.x series to version increment automation this should have PR's created with 1.4.0 version increment. Thanks

prudhvigodithi avatar Feb 01 '24 00:02 prudhvigodithi

Hey @DarshitChanpura I have added 1.x series to version increment automation this should have PR's created with 1.4.0 version increment. Thanks

Thank you @prudhvigodithi . This did create PRs however the CI build seems to not have run for 1.4.0 even though security plugin is added to 1.4 manifest which has caused the artifact to not be generated, and hence the CI is still failing due to missing artifact

DarshitChanpura avatar Feb 05 '24 15:02 DarshitChanpura

Hi, @DarshitChanpura, sorry for the late, the opensearch-security-1.4.0.0 is in place now,, could you trigger the test again on your PR to see how it works? thanks!

jordarlu avatar Mar 15 '24 16:03 jordarlu

@jordarlu the windows artifact seems to not be avaiable yet: https://ci.opensearch.org/ci/dbc/distribution-build-opensearch/1.4.0/1389/windows/x64/zip/builds/opensearch/plugins/opensearch-security-1.4.0.0.zip

DarshitChanpura avatar Mar 19 '24 20:03 DarshitChanpura

@jordarlu @prudhvigodithi windows 1.4 artifacts are not available yet. This is blocking this PR: https://github.com/opensearch-project/security-dashboards-plugin/pull/1951, can we generate those?

derek-ho avatar May 14 '24 18:05 derek-ho

Hi @derek-ho @DarshitChanpura was this issue resolved?

gaiksaya avatar May 28 '24 19:05 gaiksaya

@gaiksaya not yet. The windows artifact is not yet available: https://ci.opensearch.org/ci/dbc/distribution-build-opensearch/1.4.0/1389/windows/x64/zip/builds/opensearch/plugins/opensearch-security-1.4.0.0.zip

DarshitChanpura avatar May 29 '24 17:05 DarshitChanpura

Hi @DarshitChanpura I can access it now https://ci.opensearch.org/ci/dbc/distribution-build-opensearch/1.4.0/latest/windows/x64/zip/builds/opensearch/plugins/opensearch-security-1.4.0.0.zip Can you please check and close the issue if it is resolved?

Thanks!

gaiksaya avatar May 29 '24 18:05 gaiksaya

yes, I can too. Thank you for fixing it @gaiksaya !

DarshitChanpura avatar May 29 '24 20:05 DarshitChanpura