opensearch-build icon indicating copy to clipboard operation
opensearch-build copied to clipboard

Get CI Image Tag should be published as a GitHub action

Open peternied opened this issue 1 year ago • 2 comments

Is your feature request related to a problem? Please describe

There is an outstanding request to have repositories to make changes to use get-ci-image-tag.yml to select a docker image. As suggested this is a hardcoded reference to a file at @main

Describe the solution you'd like

This should be published as a GitHub action so the dependency / upgrade cycle is available for repositories to adopt as needed and it breaks a dependency loop.

Describe alternatives you've considered

No response

Additional context

  • See this conversation that has prompted this issue https://github.com/opensearch-project/security/pull/3868#discussion_r1430710703

peternied avatar Dec 19 '23 15:12 peternied

[Untriage] Hey @peternied I see your point to publish this entire setup as an Github action (example opensearch-project/opensearch-ci-image-by-tag@v1) rather than querying the yaml file directly from the build repo in the main branch. As of now the build repo is not branched or versioned, main acts a single source of truth so get-ci-image-tag.yml part of the main branch is the source for the repos, can you please share the immediate issues you have with this approach? Thank you

Adding @bbarani @peterzhuamazon @gaiksaya we should consider this as an enhancement to move this logic to a seperate repo (having its own versioning) and use it as an github action.

prudhvigodithi avatar Dec 19 '23 19:12 prudhvigodithi

This can be an enhancement but is not required to do at the moment. Adding as a good first issue for now.

Thanks.

peterzhuamazon avatar Mar 18 '24 18:03 peterzhuamazon