opensearch-benchmark icon indicating copy to clipboard operation
opensearch-benchmark copied to clipboard

Support opensearch-py Client Connections (urllib3httpconnection, requestshttpconnection)

Open saimedhi opened this issue 1 year ago • 2 comments

Is your feature request related to a problem? Please describe. The objective is to extract opensearch-py client performance metrics in opensearch-benchmark with various connections (urllib3httpconnection, requestshttpconnection, aiohttpconnection). The current code exclusively uses aiohttpconnection. Historically, opensearch-benchmark supported urllib3httpconnection, and at a different time, aiohttpconnection. Aim to introduce the flexibility to choose between these connections, allowing users to gain insights into their respective performances.

Describe the solution you'd like Enable opensearch-benchmark to work with urllib3httpconnection and requestshttpconnection for opensearch-py client. Provide an option to switch the client connection using an argument in the execute-test command.

saimedhi avatar Jan 11 '24 01:01 saimedhi

It will be ideal to be able to have OSB support different clients. The precise mechanism and interfaces need to be properly scoped out and designed. Meanwhile, would suggest changing the title of this PR -- "multiple" often implies "concurrent".

gkamat avatar Jan 16 '24 19:01 gkamat

I am working on this issue.

saimedhi avatar Jan 16 '24 19:01 saimedhi

@saimedhi Is this still being worked on?

IanHoang avatar Oct 01 '24 20:10 IanHoang

@saimedhi Is this still being worked on?

Hello @IanHoang, Currently I am working on dashboards-flow-framework issues. Please feel free to take up this issue, Thank you.

Issue progress:

  • Tried implementing it here #445.
  • As per the suggestion on the PR, Added service time metrics calculations to OpenSearch-Py client.
  • So, code implemented in PR 445 should change to use service time metrics from opensearch-py.

saimedhi avatar Oct 01 '24 21:10 saimedhi