opensearch-benchmark icon indicating copy to clipboard operation
opensearch-benchmark copied to clipboard

Rename results_publishing

Open IanHoang opened this issue 2 years ago • 3 comments

Is your feature request related to a problem? Please describe.

Results_publishing is kinda clunky. Let's update this to reporting

Describe the solution you'd like

A clear and concise description of what you want to happen.

Describe alternatives you've considered

A clear and concise description of any alternative solutions or features you've considered.

Additional context

Add any other context or screenshots about the feature request here.

IanHoang avatar May 25 '23 17:05 IanHoang

Hi, is this the results_publisher.py in the osbenchmark folder.I don't find anything named results_publishing.py

AManaswini avatar Sep 30 '23 05:09 AManaswini

Yes, @AManaswini this is the results_publisher.py. results_publishing is in the benchmark.ini template and requires changing as well. You may need to re-revert this commit or you can reference the changes that were partially made in this commit. https://github.com/opensearch-project/opensearch-benchmark/pull/353

IanHoang avatar Oct 18 '23 19:10 IanHoang

@IanHoang , @AManaswini - a follow up question here, when I look up "results_publishing" across the repository it also brings up code references which partially include this search term. configure_results_publishing_params in benchmark.py and include_in_results_publishing in workload.py.

Should these also be renamed to be consistent with the refactoring?

soumyatanwar avatar Oct 22 '23 00:10 soumyatanwar