ml-commons icon indicating copy to clipboard operation
ml-commons copied to clipboard

Prevents future UT build issues addresses #2967

Open brianf-aws opened this issue 1 year ago • 0 comments

Description

Depending on the GitHub CI workflow executes it will invoke ./gradlew build which will run tests on random parameters every time, there are local-code's that will break a build one of them being az-Cyrl. The solution here was preventing (by explicitly writing the local to be set to en-US) Github actions building on these random parameters that will interrupt a build and lose time. Manual testing was done to prove that using this flag breaks a build, you can check the issue #2967 or you can run (locally) ./gradlew build -Dtests.local=az-Cyrl to see it breaks

TLDR:

  • This one line change prevents future build fails by manually changing the local code to avoid UT build failures on -Dtests.locale=az-Cyrl if you get unlucky with that randomized build parameter

Related Issues

Resolves #2967

Check List

  • [X] New functionality includes testing.
  • [X] Commits are signed per the DCO using --signoff.
  • [X] Public documentation issue/PR created.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. For more information on following Developer Certificate of Origin and signing off your commits, please check here.

brianf-aws avatar Sep 24 '24 00:09 brianf-aws