ml-commons icon indicating copy to clipboard operation
ml-commons copied to clipboard

add config field in MLToolSpec for static parameters

Open jngz-es opened this issue 1 year ago • 1 comments

Description

Add config field in MLToolSpec to support static parameters in tool execution.

Related Issues

https://github.com/opensearch-project/ml-commons/issues/2836 https://github.com/opensearch-project/ml-commons/issues/2918

Check List

  • [ ] New functionality includes testing.
  • [ ] New functionality has been documented.
  • [ ] API changes companion pull request created.
  • [ ] Commits are signed per the DCO using --signoff.
  • [ ] Public documentation issue/PR created.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. For more information on following Developer Certificate of Origin and signing off your commits, please check here.

jngz-es avatar Sep 23 '24 18:09 jngz-es

The flow framework issue, https://github.com/opensearch-project/flow-framework/issues/878.

jngz-es avatar Sep 23 '24 20:09 jngz-es

@reuschling Can you help review this PR?

yuye-aws avatar Sep 24 '24 09:09 yuye-aws

@jngz-es Can you please provide an example on how to use tool config?

yuye-aws avatar Sep 24 '24 09:09 yuye-aws

@jngz-es Can you please provide an example on how to use tool config?

Provided an example in the description section.

jngz-es avatar Sep 24 '24 21:09 jngz-es

Pinging @reuschling to review the PR.

yuye-aws avatar Oct 18 '24 00:10 yuye-aws

Pinging @reuschling to review the PR.

Thanks @yuye-aws for prompting review on this. Thanks @Zhangxunmt for approval. Thanks @dhrubo-os for your initial review.

Code freeze / 2.18 RC generation is next Tuesday Oct 22. Downstream plugin PRs (https://github.com/opensearch-project/flow-framework/pull/899) are dependent on this one being merged and need time to update and consume tne new snapshots, get proper reviews, and merge before code freeze.

Please do not wait until the last minute to get this merged; last-minute PR merges have occurred in at least 2 previous releases and this one's been open for a few weeks. I'm sensing a pattern here.

CC: @minalsha @ylwu-amzn

dbwiddis avatar Oct 18 '24 05:10 dbwiddis