ml-commons icon indicating copy to clipboard operation
ml-commons copied to clipboard

Added Conversation API in MLClient

Open owaiskazi19 opened this issue 1 year ago • 3 comments

Description

Added Conversation API in MLClient

Issues Resolved

[List any issues this PR will resolve]

Check List

  • [ ] New functionality includes testing.
    • [ ] All tests pass
  • [ ] New functionality has been documented.
    • [ ] New functionality has javadoc added
  • [ ] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. For more information on following Developer Certificate of Origin and signing off your commits, please check here.

owaiskazi19 avatar Mar 18 '24 19:03 owaiskazi19

@dhrubo-os @jngz-es @rbhavna can you take a look? Thanks

owaiskazi19 avatar Mar 18 '24 19:03 owaiskazi19

Codecov Report

Attention: Patch coverage is 55.55556% with 8 lines in your changes are missing coverage. Please review.

Project coverage is 81.89%. Comparing base (c233356) to head (1e74bab).

:exclamation: Current head 1e74bab differs from pull request most recent head 03d19b1. Consider uploading reports for the commit 03d19b1 to get more accurate results

Files Patch % Lines
...ction/conversation/CreateConversationResponse.java 0.00% 8 Missing :warning:
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #2211      +/-   ##
============================================
- Coverage     81.91%   81.89%   -0.02%     
- Complexity     5719     5724       +5     
============================================
  Files           547      547              
  Lines         23064    23082      +18     
  Branches       2378     2378              
============================================
+ Hits          18892    18903      +11     
- Misses         3227     3235       +8     
+ Partials        945      944       -1     
Flag Coverage Δ
ml-commons 81.89% <55.55%> (-0.02%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Mar 18 '24 20:03 codecov[bot]

Yes, we need to follow the new names. Use Memory to replace Conversation, and Message to replace Interaction.

Zhangxunmt avatar Mar 19 '24 19:03 Zhangxunmt

@owaiskazi19 Do you want to try to get this into 2.18?

austintlee avatar Sep 29 '24 00:09 austintlee