ml-commons icon indicating copy to clipboard operation
ml-commons copied to clipboard

Add more information in log to help troubleshooting.

Open xluo-aws opened this issue 1 year ago • 4 comments

Description

[Describe what this change achieves]

Issues Resolved

[List any issues this PR will resolve]

Check List

  • [ ] New functionality includes testing.
    • [ ] All tests pass
  • [ ] New functionality has been documented.
    • [ ] New functionality has javadoc added
  • [ ] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. For more information on following Developer Certificate of Origin and signing off your commits, please check here.

xluo-aws avatar Jan 09 '24 12:01 xluo-aws

@xluo-aws Hi can you rebase with the main branch first and make the CI pass before we merge?

b4sjoo avatar Jan 12 '24 22:01 b4sjoo

@xluo-aws Hi can you rebase with the main branch first and make the CI pass before we merge?

Waiting for instruction on one of the exceptional case handling.

xluo-aws avatar Jan 16 '24 07:01 xluo-aws

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (d0895bb) 82.94% compared to head (d766e0b) 82.92%.

Files Patch % Lines
.../ml/engine/algorithms/agent/MLChatAgentRunner.java 66.66% 1 Missing and 1 partial :warning:
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #1847      +/-   ##
============================================
- Coverage     82.94%   82.92%   -0.03%     
+ Complexity     5414     5412       -2     
============================================
  Files           521      521              
  Lines         21709    21712       +3     
  Branches       2213     2214       +1     
============================================
- Hits          18007    18005       -2     
- Misses         2807     2811       +4     
- Partials        895      896       +1     
Flag Coverage Δ
ml-commons 82.92% <71.42%> (-0.03%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Jan 24 '24 03:01 codecov[bot]

@xluo-aws are you working on this issue?

dhrubo-os avatar Mar 01 '24 08:03 dhrubo-os