k-NN icon indicating copy to clipboard operation
k-NN copied to clipboard

[DO NOT MERGE][NEED INITIAL FEEDBACK]Introduces NativeEngineKNNQuery which executes ANN on rewrite

Open shatejas opened this issue 1 year ago • 1 comments

Description

Pending unit test,

All integration tests are passing. Cannot support radial currently since k is not significant, there are ways to do it but since its not planned for 2.17 this should work

Related Issues

Resolves #[Issue number to be closed when this PR is merged]

Check List

  • [ ] New functionality includes testing.
  • [ ] New functionality has been documented.
  • [ ] API changes companion pull request created.
  • [ ] Commits are signed per the DCO using --signoff.
  • [ ] Public documentation issue/PR created.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. For more information on following Developer Certificate of Origin and signing off your commits, please check here.

shatejas avatar Jul 25 '24 00:07 shatejas

@shatejas Lets ensure all CI are working. I know this code is only for feedback. but successful CIs gives confidence.

navneet1v avatar Jul 25 '24 00:07 navneet1v

@shatejas do you think it doesnt need changelog?

jmazanec15 avatar Aug 01 '24 23:08 jmazanec15

@shatejas do you think it doesnt need changelog?

Wasn't planning on adding it. Doesn't seem to be significant enough for users to make it to change log

shatejas avatar Aug 01 '24 23:08 shatejas

Please make the change in changelog.md file

navneet1v avatar Aug 01 '24 23:08 navneet1v

Please make the change in changelog.md file

https://github.com/opensearch-project/k-NN/pull/1877#issuecomment-2264201750

shatejas avatar Aug 02 '24 00:08 shatejas

@shatejas do you think it doesnt need changelog?

Wasn't planning on adding it. Doesn't seem to be significant enough for users to make it to change log

I think we should put a change log. It is changing the complete query execution flow.

navneet1v avatar Aug 02 '24 00:08 navneet1v

Minor comments, overall code looks good to me

navneet1v avatar Aug 05 '24 18:08 navneet1v

@shatejas please resolve conflicts.

navneet1v avatar Aug 05 '24 22:08 navneet1v

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.x 2.x
# Navigate to the new working tree
cd .worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-1877-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 df7627c6e580843beb2361f5c2ec3519efd52280
# Push it to GitHub
git push --set-upstream origin backport/backport-1877-to-2.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-1877-to-2.x.