helm-charts icon indicating copy to clipboard operation
helm-charts copied to clipboard

OpenSearch Dashboards: wrong check for `startupProbe`

Open rursprung opened this issue 1 year ago • 2 comments

the startupProbe in the helm chart is only added if readinessProbe is defined, this is probably a simple copy&paste mistake: https://github.com/opensearch-project/helm-charts/blob/72078b10070c44e560f78119d79b3930e2013b79/charts/opensearch-dashboards/templates/deployment.yaml#L105-L110

for reference: for OpenSearch the content is just always added: https://github.com/opensearch-project/helm-charts/blob/72078b10070c44e560f78119d79b3930e2013b79/charts/opensearch/templates/statefulset.yaml#L335-L338

rursprung avatar Feb 27 '23 11:02 rursprung

@rursprung do you intend to pick up this issue?

TheAlgo avatar Mar 02 '23 06:03 TheAlgo

@rursprung do you intend to pick up this issue?

no. since i'm not using the helm charts (i just looked at them to see how you did some things here) i couldn't test the change, so i'd prefer not to change things here

rursprung avatar Mar 02 '23 12:03 rursprung