helm-charts icon indicating copy to clipboard operation
helm-charts copied to clipboard

[BUG][Opensearch]Difference Node role between Official document and Helm chart value.yaml

Open type-kimchi opened this issue 2 years ago • 3 comments

Dear team,

Official document let me know master node.roles below as https://opensearch.org/docs/latest/opensearch/cluster/

node.roles: [ cluster_manager ]

By the way in the helm chart

roles:

  • master
  • ingest
  • data
  • remote_cluster_client

helm is going with master ? or cluster_manager is right ? please let me know.

Thanks, Best regards.

type-kimchi avatar Dec 28 '22 00:12 type-kimchi

[Triage] Hey @type-kimchi yes thats true the roles has to be updated to change cluster_manager for main branch of this repo, the 1.x branch uses 1.x version of OpenSearch so it can continue to use master. Also just FYI https://opensearch.org/blog/Adopting-inclusive-language-across-OpenSearch/ You can also edit the line in chart to change to cluster_manager, please raise a PR if you think it has to be cluster_manager as the default value. Thank you

prudhvigodithi avatar Jan 05 '23 19:01 prudhvigodithi

It's not about only values.yaml. The role master is used in several places, it must be done comprehensively, e.g.:

https://github.com/opensearch-project/helm-charts/blob/1a2ba749b7215095adda7ee592b98ebadf946373/charts/opensearch/templates/statefulset.yaml#L357

I want to mention that it must be done because master is deprecated and may be removed in future releases of OpenSearch.

czepiec avatar Jan 27 '23 09:01 czepiec

strongly agree with you @czepiec

type-kimchi avatar Feb 21 '23 06:02 type-kimchi