helm-charts icon indicating copy to clipboard operation
helm-charts copied to clipboard

[BUG]Helm chart-releaser parallel release.

Open prudhvigodithi opened this issue 2 years ago • 2 comments

Describe the bug When doing 2 releases from main (2.x) and 1.x (1.x) branch which recently happened with 2.2.1 and 1.3.5, the release 2.2.1 failed to update the gh-pages index.yml file. Assuming this caused a race condition. failed action: https://github.com/opensearch-project/helm-charts/actions/runs/2975206760/attempts/1

To Reproduce By doing 2 releases from 2 different branches within the same repo.

Expected behavior Ideally the chart-releaser should handle this scenario and update index.yml file with 2 release chart versions.

Chart Name OpenSearch and OpenSearch dashboard.

prudhvigodithi avatar Sep 02 '22 02:09 prudhvigodithi

Looks like concurrency needs to be configured: https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#example-only-cancel-in-progress-jobs-or-runs-for-the-current-workflow

smlx avatar Sep 02 '22 03:09 smlx

[Triage] We need to explore the concurrency but the solution now is to merge PRs one by one with delays in between.

peterzhuamazon avatar Sep 29 '22 18:09 peterzhuamazon