helm-charts icon indicating copy to clipboard operation
helm-charts copied to clipboard

[BUG][opensearch] dead "minimum_master_nodes" setting still listed

Open rursprung opened this issue 3 years ago • 4 comments

Describe the bug the opensearch chart still contains the commented-out discovery.zen.minimum_master_nodes: https://github.com/opensearch-project/helm-charts/blob/12e6af67dd6e0e3945c9b3064579dd76381160d3/charts/opensearch/values.yaml#L50-L52

however, since Elasticsearch 7.0 this setting has been ignored: release notes for 7.0 (see also elastic/elasticsearch#37868)

accordingly this should probably be removed (unclear: should something else be added instead as a recommendation?)

To Reproduce check the default config provided in the helm charts.

Expected behavior only settings are listed which are still supported and which have an effect.

Chart Name opensearch

Screenshots n/a

Host/Environment (please complete the following information): n/a

Additional context i saw that this has also been touched upon in #54

rursprung avatar Dec 10 '21 13:12 rursprung

Yes this needs to be removed from the values.yaml as per my knowledge to avoid any confusion. I will raise a fix for this to remove it if @rursprung is not planning any PR

TheAlgo avatar Dec 10 '21 13:12 TheAlgo

i'm not planning to contribute a PR here because i'm not familiar enough with what the proper settings would be for this use-case. i'm actually hoping to see what you'll be doing :D

rursprung avatar Dec 10 '21 13:12 rursprung

@TheAlgo any progress? Thanks.

peterzhuamazon avatar Dec 14 '21 21:12 peterzhuamazon

@TheAlgo Any updates? Thanks.

peterzhuamazon avatar Feb 20 '22 17:02 peterzhuamazon