documentation-website icon indicating copy to clipboard operation
documentation-website copied to clipboard

Added from and to parameters to top N queries to specify time range

Open LilyCaroline17 opened this issue 1 year ago • 8 comments

Description

Added from and to parameters to documentation for top N queries References PR: opensearch-project/query-insights#84 Issues PR: opensearch-project/query-insights#12

Checklist

  • [x] By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and subject to the Developers Certificate of Origin. For more information on following Developer Certificate of Origin and signing off your commits, please check here.

LilyCaroline17 avatar Aug 30 '24 07:08 LilyCaroline17

Thank you for submitting your PR. The PR states are In progress (or Draft) -> Tech review -> Doc review -> Editorial review -> Merged.

Before you submit your PR for doc review, make sure the content is technically accurate. If you need help finding a tech reviewer, tag a maintainer.

When you're ready for doc review, tag the assignee of this PR. The doc reviewer may push edits to the PR directly or leave comments and editorial suggestions for you to address (let us know in a comment if you have a preference). The doc reviewer will arrange for an editorial review.

github-actions[bot] avatar Aug 30 '24 07:08 github-actions[bot]

I'm assuming that this is part of 2.17 so adding the 2.17 label.

kolchfa-aws avatar Aug 30 '24 12:08 kolchfa-aws

Thank you! Applying "Done but waiting to merge" label to put this in the 2.17 editorial queue starting 9/11. This PR will be merged before the release.

kolchfa-aws avatar Aug 30 '24 20:08 kolchfa-aws

@kolchfa-aws Let's not merge this one in 2.17, since we still need some time to review the underlying PR: https://github.com/opensearch-project/query-insights/pull/84 and we might skip it for 2.17.

ansjcy avatar Sep 04 '24 19:09 ansjcy

@ansjcy Sure, I'll put it on hold for now.

kolchfa-aws avatar Sep 04 '24 19:09 kolchfa-aws

@ansjcy should we mark this for 2.18 if ew're not ready with the feature merge for 2.17 ?

kkhatua avatar Sep 12 '24 17:09 kkhatua

@ansjcy Looks like the code is merged and backported to 2.x so this made it to 2.17. Removing the "on hold" label.

kolchfa-aws avatar Sep 13 '24 16:09 kolchfa-aws

We are planing to ship this for 2.18 - as we merged the corresponding change into 2.x but didn't backport it into 2.17. Let's change the label to 2.18.

ansjcy avatar Sep 13 '24 17:09 ansjcy