documentation-website icon indicating copy to clipboard operation
documentation-website copied to clipboard

Add hunspell token filter #8061

Open AntonEliatra opened this issue 1 year ago • 6 comments
trafficstars

Description

Add hunspell token filter

Issues Resolved

Closes https://github.com/opensearch-project/documentation-website/issues/8061

Version

all

Checklist

  • [x] By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and subject to the Developers Certificate of Origin. For more information on following Developer Certificate of Origin and signing off your commits, please check here.

AntonEliatra avatar Aug 22 '24 14:08 AntonEliatra

Thank you for submitting your PR. The PR states are In progress (or Draft) -> Tech review -> Doc review -> Editorial review -> Merged.

Before you submit your PR for doc review, make sure the content is technically accurate. If you need help finding a tech reviewer, tag a maintainer.

When you're ready for doc review, tag the assignee of this PR. The doc reviewer may push edits to the PR directly or leave comments and editorial suggestions for you to address (let us know in a comment if you have a preference). The doc reviewer will arrange for an editorial review.

github-actions[bot] avatar Aug 22 '24 14:08 github-actions[bot]

I did not include dedup parameter, as it does not seem to work. The duplicates are always returned.

Also the configuration for indices.analysis.hunspell.dictionary.ignore_case, does not seem to have any impact.

Also was unable to see any difference in behaviour when adding indices.analysis.hunspell.dictionary.lazy: true If there is a difference I can add it back in.

Also according to these docs you should be able to change the default directory for hunspell dictionaries, but I was not able to get this to work. If anyone is able to confirm if this works and what format is expected, I can update the PR accordingly

AntonEliatra avatar Aug 22 '24 14:08 AntonEliatra

@udabhas Will you see the preceding comments from the technical writer and provide your feedback? Thank you.

vagimeli avatar Aug 22 '24 22:08 vagimeli

@AntonEliatra I would enter this as a bug in the main OpenSearch repo.

kolchfa-aws avatar Aug 23 '24 17:08 kolchfa-aws

Bug issue added https://github.com/opensearch-project/OpenSearch/issues/15417

and dedup parameter added to the PR

AntonEliatra avatar Aug 26 '24 12:08 AntonEliatra

@varun-lodaya The documentation is awaiting tech review and approval, which is delaying progress. Could you please suggest alternative reviewers who can assist with this task in a timely manner? We're eager to move this forward. Thank you.

vagimeli avatar Aug 28 '24 13:08 vagimeli

@varun-lodaya The documentation is awaiting tech review and approval, which is delaying progress. Could you please suggest alternative reviewers who can assist with this task in a timely manner? We're eager to move this forward. Thank you.

@varun-lodaya This is over a month old. We need tech review approval to move it forward in the documentation process. Please review this week or provide a peer who can review it. Thank you.

vagimeli avatar Oct 03 '24 16:10 vagimeli