documentation-website icon indicating copy to clipboard operation
documentation-website copied to clipboard

Add doc for binary format support in k-NN

Open junqiu-lei opened this issue 1 year ago • 3 comments

Description

Add doc for binary format support in k-NN

Issues Resolved

Closes https://github.com/opensearch-project/documentation-website/issues/7835

Version

Since 2.16

Frontend features

N/A

Checklist

  • [x] By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and subject to the Developers Certificate of Origin. For more information on following Developer Certificate of Origin and signing off your commits, please check here.

junqiu-lei avatar Jul 25 '24 23:07 junqiu-lei

Thank you for submitting your PR. The PR states are In progress (or Draft) -> Tech review -> Doc review -> Editorial review -> Merged.

Before you submit your PR for doc review, make sure the content is technically accurate. If you need help finding a tech reviewer, tag a maintainer.

When you're ready for doc review, tag the assignee of this PR. The doc reviewer may push edits to the PR directly or leave comments and editorial suggestions for you to address (let us know in a comment if you have a preference). The doc reviewer will arrange for an editorial review.

github-actions[bot] avatar Jul 25 '24 23:07 github-actions[bot]

Could you add hamming as space type in https://opensearch.org/docs/latest/search-plugins/knn/knn-score-script/?

The difference between hammingbit and hamming is that, hamming works only with knn field of binary data type whereas hammingbit works with long and binary type(https://opensearch.org/docs/latest/search-plugins/sql/datatypes/).

heemin32 avatar Jul 29 '24 19:07 heemin32

Could you add hamming as space type in https://opensearch.org/docs/latest/search-plugins/knn/knn-score-script/?

The difference between hammingbit and hamming is that, hamming works only with knn field of binary data type whereas hammingbit works with long and binary type(https://opensearch.org/docs/latest/search-plugins/sql/datatypes/).

Added

junqiu-lei avatar Jul 29 '24 21:07 junqiu-lei

@junqiu-lei @kolchfa-aws Please see my comments and changes and let me know if you have any questions. Thanks!

The changes LGTM, thanks!

junqiu-lei avatar Aug 01 '24 16:08 junqiu-lei