opensearch-project
Added documentation for managed identity support in repository-azure plugin
Description
Added documentation for managed identity support in repository-azure plugin
Issues Resolved
Closes https://github.com/opensearch-project/documentation-website/issues/6874
Checklist
- [x] By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and subject to the Developers Certificate of Origin. For more information on following Developer Certificate of Origin and signing off your commits, please check here.
Hello @hdhalter, sorry for delaying this PR, i hope i am in time for the 30-april cut off.
In addition, i did not manage to find any dedicated section related to repository-azure plugin, so i end up adding a new section, below the Amazon S3 section in docs/latest/tuning-your-cluster/availability-and-recovery/snapshots/snapshot-restore/. Welcome suggestions if others view this differently. Cheers.
No worries at all, @chengwushi-netapp! Thanks so much for creating this. I'll send it through the review process and we'll check on the location. In the meantime, can you please see if you can address any of the style check errors?
@hdhalter I just noticed the version mismatch, it will be for 2.15.0 (not current release), sorry about that
@hdhalter I just noticed the version mismatch, it will be for 2.15.0 (not current release), sorry about that
OK, no worries. I'll update.
Hello @hdhalter, for your information, the PR for managed identity support, https://github.com/opensearch-project/OpenSearch/pull/12559, is merged and backported to 2.x. Just wondering if there is any more action items needed from my end to move this documentation PR forward?
Hello @hdhalter, for your information, the PR for managed identity support, opensearch-project/OpenSearch#12559, is merged and backported to 2.x. Just wondering if there is any more action items needed from my end to move this documentation PR forward?
Will the feature be released in 2.15 or has it been merged independently? Let me send it through a doc and editorial review. Just keep an eye out for questions from the tech writer and editor. Thanks.
Need more insight on line 343
@Naarcha-AWS , as mentioned above, i have added some descriptions about the configuration when using token credential. Also, i have make a slight changes to the layout, i hope that would be clearer to the user reading it.
feel free to make any changes if needed and do remember to pull the latest branch before editing, because I did a rebase of the branch. Cheers. Chengwu
Need more insight on line 343
@Naarcha-AWS , as mentioned above, i have added some descriptions about the configuration when using token credential. Also, i have make a slight changes to the layout, i hope that would be clearer to the user reading it.
feel free to make any changes if needed and do remember to pull the latest branch before editing, because I did a rebase of the branch. Cheers. Chengwu
Thanks! Taking a look now.
Hello @Naarcha-AWS @andrross @scrawfor99 @hdhalter, just wondering if there is anymore feedback in this PR which i could address? Cheers, Chengwu
@chengwushi-netapp: Our reviews are complete. Let me know if this is ready to merge in advance of the 2.15 release.
@chengwushi-netapp: Our reviews are complete. Let me know if this is ready to merge in advance of the 2.15 release.
Thank you @Naarcha-AWS and @natebower for the reviews. Yes, I believe this is ready to be merged, given that the implementation PR for managed identity support has already merged and backported to 2.15.0.
@hdhalter Do correct me if am wrong about this.