documentation-website icon indicating copy to clipboard operation
documentation-website copied to clipboard

Add metadata fields for mappings (content gap initiative)

Open vagimeli opened this issue 1 year ago • 7 comments
trafficstars

Description

Add documentation to address content gaps

Issues Resolved

Closes #4300 See also PR #7115

Checklist

  • [X] By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and subject to the Developers Certificate of Origin. For more information on following Developer Certificate of Origin and signing off your commits, please check here.

vagimeli avatar Apr 09 '24 21:04 vagimeli

Status = Need SME for tech review and to answer the following questions:

  1. What are the mapping limits settings, their default values, and how to configure them if needed.
  2. Does OpenSearch allow removal of mapping types and defining mapping types within an index? If so, SME should provide information to include in documentation. Do we have guidance on how to structure data without relying on mapping types?
  3. How does user delete a mapping? Provide example tutorial.

vagimeli avatar Apr 10 '24 00:04 vagimeli

Does OpenSearch allow removal of mapping types and defining mapping types within an index?

Do you mean custom types here which were present in earlier versions on elasticsearch? If yes, the mapping types have been deprecated since OS 1.0 itself

mgodwan avatar Apr 11 '24 17:04 mgodwan

Does OpenSearch allow removal of mapping types and defining mapping types within an index?

Do you mean custom types here which were present in earlier versions on elasticsearch? If yes, the mapping types have been deprecated since OS 1.0 itself

We can note this in the documentation. We do need to include information and examples about deleting a mapping. Will you help with that topic too?

vagimeli avatar Apr 11 '24 17:04 vagimeli

@mgodwan I've added first-pass drafts of the mappings documentation. When you review these docs, please verify that the code examples are relevant (I tested them using Dev Tools, but am not sure if these examples are most relevant to our users.) Also, please verify that the narrative text is accurate and I haven't miscommunicated any information. Thank you!

vagimeli avatar Apr 17 '24 19:04 vagimeli

coming from #4300 i had hoped to find some more content on the analyzer, normalizer, etc. attributes in this PR but don't see them here. i think it'd be great if this could be documented a bit more as it seems that not all of these can be used with all field types (e.g. normalizer seems to work with keyword but not text fields while analyzer works with text but not keyword?). even just having the information that these are type-specific would be nice, and then additionally the per-type documentation should go into details. or maybe the overview could also contain a list of field types supporting each of the attributes? these pseudo-generic attributes (exist everywhere but can't be set everywhere) are quite hard to deal with without (good) documentation

rursprung avatar Jun 11 '24 09:06 rursprung

@rursprung I see this PR as more of metadata fields being documented and not mapping params for field types.

See this PR for for mapping parameters: https://github.com/opensearch-project/documentation-website/pull/7115 which contain params like analyzer, doc_values, etc.

Once we add more documentation for each field type (e.g. keyword, text), we can mention there what params each field type supports.

mgodwan avatar Jun 11 '24 10:06 mgodwan

@mgodwan I've addressed your feedback. Will you give this a final review and approval? Once you're good with it, I'll move it forward to editorial review and then publish it. Thank you for all your support :)

vagimeli avatar Jul 17 '24 18:07 vagimeli

Thanks for helping with improving the feature documentation :slightly_smiling_face:

mgodwan avatar Jul 31 '24 07:07 mgodwan

A few small fixes and suggestions, otherwise LGTM.

@Naarcha-AWS Thank you for reviewing this PR. I accepted your suggestions and revised areas where you left comments.

vagimeli avatar Aug 28 '24 21:08 vagimeli

@natebower This PR is ready for editorial at your availability. Thank you.

vagimeli avatar Aug 28 '24 21:08 vagimeli