data-prepper icon indicating copy to clipboard operation
data-prepper copied to clipboard

Added custom exceptions and code refactoring

Open asifsmohammed opened this issue 2 years ago • 1 comments

Signed-off-by: Asif Sohail Mohammed [email protected]

Description

  • Addressed some left out feedback from peer forwarder client PR https://github.com/opensearch-project/data-prepper/pull/1677
  • Added custom exceptions which will be thrown in decorator
  • Updated WireEvent and WireEvents to have public constructor for deserializing in server
  • Created a bean for PeerForwarderClientFactory
  • Added client and server thread to configuration
  • Updated peer forwarding uri from /log/ingest to /event/forward

Issues Resolved

Check List

  • [x] New functionality includes testing.
  • [ ] New functionality has been documented.
    • [x] New functionality has javadoc added
  • [x] Commits are signed with a real name per the DCO

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. For more information on following Developer Certificate of Origin and signing off your commits, please check here.

asifsmohammed avatar Aug 29 '22 21:08 asifsmohammed

Codecov Report

Merging #1698 (04661af) into main (caebb19) will decrease coverage by 0.08%. The diff coverage is 83.09%.

@@             Coverage Diff              @@
##               main    #1698      +/-   ##
============================================
- Coverage     93.18%   93.09%   -0.09%     
- Complexity     1332     1345      +13     
============================================
  Files           176      178       +2     
  Lines          3917     3954      +37     
  Branches        312      314       +2     
============================================
+ Hits           3650     3681      +31     
- Misses          193      197       +4     
- Partials         74       76       +2     
Impacted Files Coverage Δ
...ch/dataprepper/peerforwarder/model/WireEvents.java 75.00% <0.00%> (ø)
...pper/peerforwarder/PeerForwarderConfiguration.java 78.61% <73.33%> (-1.52%) :arrow_down:
...rch/dataprepper/peerforwarder/model/WireEvent.java 83.33% <83.33%> (ø)
...pper/peerforwarder/client/PeerForwarderClient.java 82.22% <86.66%> (+4.09%) :arrow_up:
...aprepper/peerforwarder/PeerForwarderAppConfig.java 88.88% <100.00%> (+1.38%) :arrow_up:
...pper/peerforwarder/PeerForwarderClientFactory.java 82.35% <100.00%> (+5.88%) :arrow_up:
...eerforwarder/PeerForwardingProcessorDecorator.java 100.00% <100.00%> (ø)
...eerForwarderPluginIdentificationKeysException.java 100.00% <100.00%> (ø)
...ption/UnsupportedPeerForwarderPluginException.java 100.00% <100.00%> (ø)
...rwarder/discovery/AwsCloudMapPeerListProvider.java 95.12% <0.00%> (+2.43%) :arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

codecov-commenter avatar Aug 29 '22 22:08 codecov-commenter