dashboards-maps icon indicating copy to clipboard operation
dashboards-maps copied to clipboard

[UI Request] Trigger Show Error Modal in Visualize - Region Map

Open SheyGao opened this issue 6 months ago • 1 comments

Background

As part of the ongoing consistency and density improvements for the dashboards-maps plugin, I'm planning to update the show_error_modal.tsx file to enhance the UI. The specific changes we aim to implement are:

  1. Button Usage: Modify the error modal to use buttons appropriately, ensuring that primary buttons are only used for primary actions. (remove "fill")
<EuiSmallButton
  id="closeModal"
  aria-label="closeModal"
  data-testid="closeModal"
  onClick={closeModal}
  //fill
>
  Close
</EuiSmallButton>
  1. Text Size: Adjust the text size in the error modal to a smaller font for better visual consistency. (add size="s")
<EuiText size="s">
  <h2>{props.modalTitle}</h2>
</EuiText>

Issue

To proceed with these UI changes, it's essential to visually confirm the updates. However, I'm currently facing difficulties in reproducing the error modal within the Visualize - Region Map context. We attempted to import a problematic geo.json file under the Import Vector Map tab, expecting it to trigger the error modal, but it did not.

Screenshot 2024-08-20 at 5 27 59 PM

Request

Seeking assistance from the Maps team to provide guidance or steps on how to trigger the error modal in the Visualize - Region Map. This will enable us to test and refine the UI changes effectively.

SheyGao avatar Aug 21 '24 00:08 SheyGao