dashboards-maps icon indicating copy to clipboard operation
dashboards-maps copied to clipboard

[BUG] Dashboards-maps: documents size limit

Open cbeaujoin-stellar opened this issue 1 year ago • 8 comments

What is the bug?

As described here: https://github.com/opensearch-project/dashboards-maps/pull/141

Update default query document size limit to 1000, the max is from index.max_result_window size,

But in fact limitation is set to 10000 and is not aligned with index.max_result_window:

https://github.com/opensearch-project/dashboards-maps/blob/811e8b096b77c57fb820516262d5c3e3d4f43c3b/public/components/layer_config/documents_config/document_layer_source.tsx#L212

How can one reproduce the bug?

Create a map based on an index with number of documents and index.max_result_window greather than 10000. You can't set a Number of Document greater than 10k.

What is the expected behavior?

UI should be aligned with the spec:

  • Limited to the index index.max_result_window

Idealy, maybe the maps plugin should use the scroll API when index.max_result_window > 10k

What is your host/environment?

docker, v2.11.1

Do you have any screenshots?

image

Do you have any additional context?

https://forum.opensearch.org/t/dashboards-maps-documents-size-limit/17983

cbeaujoin-stellar avatar Feb 22 '24 09:02 cbeaujoin-stellar