dashboards-assistant icon indicating copy to clipboard operation
dashboards-assistant copied to clipboard

[Incontext Insights] follow up issues from #53

Open kavilla opened this issue 1 year ago • 0 comments

Address comments https://github.com/opensearch-project/dashboards-assistant/pull/53

Fast follows:

  • [ ] Change setSuggestionId to setSuggestion within the registry code
  • [x] Clean up tsconfig adding root level config.ts code PR
  • [ ] Ref to icon instead of querying the ref of the anchor for it comment
  • [ ] Cypress tests
  • [x] Break popover body down into different functional components. PR
  • [ ] Consume in alerting dashboards plugin
  • [x] UI Setting? PR
  • [x] Increase delay PR
  • [x] Onclick to document forces fade out behavior PR

Next steps (but not fast follows)

  • [ ] Research and potentially refactor to consider animation in code display: none issue prevents animation code
  • [ ] Add enabled config to repo and add to build repo env variable code
  • [ ] Convert to generic component into OSD and extend in Dashboards Assistant comment
  • [ ] Convert wrapper component to query DOM by custom attribute and mutate elements
    • [ ] Previous step will make this easier
  • [ ] Add chat icon to OpenSearch Dashboards logos so that this plugin and other plugins can reference the icon with getChrome().logos
  • [ ] Consider making key suggestions retrieve from saved objects or at least make it configurable.
  • [ ] Convert popover to a modified OUI styled component

kavilla avatar Feb 09 '24 02:02 kavilla