cross-cluster-replication icon indicating copy to clipboard operation
cross-cluster-replication copied to clipboard

Fix for Generic error for persistent task on starting replication

Open nisgoel-amazon opened this issue 1 year ago • 1 comments

Description

This change will fix the generic error coming in case of replication failed in restore phase. This change will also return the acknowledgement as 200 when replication failed in restore phase and put the failed reason in metadata store, which can be view via replication status API

Issues Resolved

https://github.com/opensearch-project/cross-cluster-replication/issues/707

Check List

  • [ ] New functionality includes testing.
    • [ ] All tests pass
  • [ ] New functionality has been documented.
    • [ ] New functionality has javadoc added
  • [ ] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. For more information on following Developer Certificate of Origin and signing off your commits, please check here.

nisgoel-amazon avatar Jun 20 '23 03:06 nisgoel-amazon

Codecov Report

Attention: Patch coverage is 33.33333% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 74.64%. Comparing base (d404742) to head (6dcbd7d). Report is 2 commits behind head on main.

:exclamation: Current head 6dcbd7d differs from pull request most recent head faa1612. Consider uploading reports for the commit faa1612 to get more accurate results

Files Patch % Lines
...TransportReplicateIndexClusterManagerNodeAction.kt 50.00% 0 Missing and 1 partial :warning:
...rch/replication/task/index/IndexReplicationTask.kt 0.00% 1 Missing :warning:
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #1003      +/-   ##
============================================
- Coverage     76.15%   74.64%   -1.52%     
+ Complexity     1042     1026      -16     
============================================
  Files           141      141              
  Lines          4785     4784       -1     
  Branches        527      527              
============================================
- Hits           3644     3571      -73     
- Misses          789      863      +74     
+ Partials        352      350       -2     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Jun 21 '23 10:06 codecov[bot]