alerting icon indicating copy to clipboard operation
alerting copied to clipboard

Published 20 hours ago • verified publisher icon opensearch-project

[Backport 2.x] Changed @Ignore to @AwaitsFix (#1245)

Open kennyzhang0819 opened this issue 2 years ago • 3 comments
trafficstars

  • Changed @Ignore to @AwaitsFix

  • added bugUrl

Issue #, if available:

Description of changes:

CheckList:

  • [x] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. For more information on following Developer Certificate of Origin and signing off your commits, please check here.

kennyzhang0819 avatar Oct 14 '23 23:10 kennyzhang0819

Manual backport of PR https://github.com/opensearch-project/alerting/pull/1245

AWSHurneyt avatar Oct 30 '23 17:10 AWSHurneyt

@kennyzhang0819 could you rebase your dev branch for this PR? Looks like there were some fixes backported to the 2.x branch that should address some of these test failures. https://github.com/opensearch-project/alerting/commit/944abf29a42ce71d8e5d62c61768f826d34b2a45

AWSHurneyt avatar Nov 02 '23 18:11 AWSHurneyt

@AWSHurneyt Hi I'm not sure if I did it right. I followed something like the following and now on my fork it says I need to create a new pull request.

git checkout backport-1245-to-2.x (the local branch name) git fetch origin git rebase origin/2.x git push origin backport-1245-to-2.x --force

kennyzhang0819 avatar Nov 04 '23 06:11 kennyzhang0819