alerting icon indicating copy to clipboard operation
alerting copied to clipboard

[BUG] Forbidden annotation org.junit.Ignore used instead of AwaitsFix

Open kennyzhang0819 opened this issue 2 years ago • 2 comments
trafficstars

Problem

  • ./gradlew build fails to run due to org.junit.Ignore being called in class SecureWorkflowRestApiIT.
  • Task :alerting:forbiddenApisTest FAILED Forbidden annotation use: org.junit.Ignore [Use AwaitsFix instead]

Solution

  • Use AwaitsFix Annotation Instead.

kennyzhang0819 avatar Oct 10 '23 03:10 kennyzhang0819

Left this comment in the PR as well, but I'll add it here too for visibility. Once successfully backported, we can close this issue.

@kennyzhang0819 Looks like the auto backport for this PR failed. Could you please manually create a backport PR? To do that, you'd want to:

  1. Create a dev branch from the 2.x branch.
  2. Copy the changes from this PR to that branch (I usually use git cherry-pick to do this).
  3. Create a new PR from your 2.x dev branch to the 2.x branch in alerting repo.

AWSHurneyt avatar Oct 13 '23 18:10 AWSHurneyt

Just did that. See #1272

kennyzhang0819 avatar Oct 14 '23 23:10 kennyzhang0819