Fix updating the parent span

[Gaganjuneja]

Description

Tracing framework after ending the current span internally set the parent as a current span in the thread context. But after this change https://github.com/opensearch-project/OpenSearch/issues/8428 now parent can be ended even before the span so the assumption that parent should always be closed after child doesnt hold true. Now setting the already ended parent as a current span doesn't make sense. Adding parent as a current span only if it is still recording

Related Issues

Resolves #9449

Check List

• [x] New functionality includes testing.
  • [x] All tests pass
• [x] New functionality has been documented.
  • [x] New functionality has javadoc added
• [x] Commits are signed per the DCO using --signoff
• [x] Commit changes are listed out in CHANGELOG.md file (See: Changelog)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. For more information on following Developer Certificate of Origin and signing off your commits, please check here.

[opensearch-trigger-bot[bot]]

Compatibility status:

Checks if related components are compatible with change bf10ff7

Incompatible components

Incompatible components: [https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/security-analytics.git]

Skipped components

Compatible components

Compatible components: [https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/performance-analyzer.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/opensearch-oci-object-storage.git]

[github-actions[bot]]

Gradle Check (Jenkins) Run Completed with:

• RESULT: UNSTABLE :grey_exclamation:
• TEST FAILURES:

      1 org.opensearch.snapshots.CloneSnapshotIT.testCloneShallowSnapshotIndex
      1 org.opensearch.search.SearchWeightedRoutingIT.testMultiGetWithNetworkDisruption_FailOpenEnabled

• URL: https://build.ci.opensearch.org/job/gradle-check/23071/
• CommitID: 0cd65e800a59349d1122d6f9c46d77e31bcc8b74 Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

[codecov[bot]]

Codecov Report

Attention: Patch coverage is 75.00000% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 71.08%. Comparing base (bf10ff7) to head (5d0f21e). Report is 983 commits behind head on main.

Files	Patch %	Lines
...ava/org/opensearch/telemetry/tracing/OTelSpan.java	0.00%	0 Missing and 1 partial :warning:

Additional details and impacted files

@@             Coverage Diff              @@
##               main    #9450      +/-   ##
============================================
- Coverage     71.17%   71.08%   -0.10%     
- Complexity    57451    57459       +8     
============================================
  Files          4776     4776              
  Lines        270795   270798       +3     
  Branches      39580    39581       +1     
============================================
- Hits         192743   192501     -242     
- Misses        61852    62061     +209     
- Partials      16200    16236      +36     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

[github-actions[bot]]

Gradle Check (Jenkins) Run Completed with:

• RESULT: SUCCESS :white_check_mark:
• URL: https://build.ci.opensearch.org/job/gradle-check/23073/
• CommitID: 5d0f21ebad3222d60e7dc9efef7436491526295c

[github-actions[bot]]

Gradle Check (Jenkins) Run Completed with:

• RESULT: UNSTABLE :grey_exclamation:
• TEST FAILURES:

      1 org.opensearch.search.pit.DeletePitMultiNodeIT.testDeleteWhileSearch

• URL: https://build.ci.opensearch.org/job/gradle-check/23072/
• CommitID: b27583dc2b55c75a70b3ce7f11eeaee2c35908e0 Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

[Gaganjuneja]

@reta Please take a look.

[opensearch-trigger-bot[bot]]

This PR is stalled because it has been open for 30 days with no activity.

[ticheng-aws]

Hi @Gaganjuneja, the PR is stalled. Is this being worked upon? Feel free to reach out to maintainers for further reviews.

[opensearch-trigger-bot[bot]]

This PR is stalled because it has been open for 30 days with no activity.

[opensearch-trigger-bot[bot]]

This PR is stalled because it has been open for 30 days with no activity.

[opensearch-trigger-bot[bot]]

This PR is stalled because it has been open for 30 days with no activity.