OpenSearch icon indicating copy to clipboard operation
OpenSearch copied to clipboard

Added rest layer changes for List all PITs and PIT segments

Open bharath-techie opened this issue 2 years ago • 33 comments

Description

The changes contain rest layer changes for list all PITs and PIT segments APIs.

Issues Resolved

https://github.com/opensearch-project/OpenSearch/issues/1147 https://github.com/opensearch-project/OpenSearch/issues/3959

Check List

  • [ ] New functionality includes testing.
    • [ ] All tests pass
  • [ ] New functionality has been documented.
    • [ ] New functionality has javadoc added
  • [ ] Commits are signed per the DCO using --signoff
  • [ ] Commit changes are listed out in CHANGELOG.md file (See: Changelog)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. For more information on following Developer Certificate of Origin and signing off your commits, please check here.

bharath-techie avatar Sep 02 '22 05:09 bharath-techie

Gradle Check (Jenkins) Run Completed with:

  • RESULT: FAILURE :x:
  • URL: https://build.ci.opensearch.org/job/gradle-check/2516/
  • CommitID: 57cc2cdcfcff164f8ca2cf2ae388a32e47f0ee11

github-actions[bot] avatar Sep 02 '22 06:09 github-actions[bot]

Gradle Check (Jenkins) Run Completed with:

  • RESULT: FAILURE :x:
  • URL: https://build.ci.opensearch.org/job/gradle-check/2517/
  • CommitID: 8c97d73ab35b889070338adce2ceccea61e17238

github-actions[bot] avatar Sep 02 '22 06:09 github-actions[bot]

Gradle Check (Jenkins) Run Completed with:

  • RESULT: FAILURE :x:
  • URL: https://build.ci.opensearch.org/job/gradle-check/2522/
  • CommitID: c733d099e3be72cd2a7df24bc581e4f9760de7d5

github-actions[bot] avatar Sep 02 '22 08:09 github-actions[bot]

Gradle Check (Jenkins) Run Completed with:

  • RESULT: FAILURE :x:
  • URL: https://build.ci.opensearch.org/job/gradle-check/2540/
  • CommitID: 5167a2c78dff07719677ea4ce0fcb78dedd443b6

github-actions[bot] avatar Sep 02 '22 12:09 github-actions[bot]

@reta @Bukhtawar can you please review this ? This is the final major PR for point in time changes. We need to check this in before code freeze (sep 7th)

bharath-techie avatar Sep 02 '22 15:09 bharath-techie

Gradle Check (Jenkins) Run Completed with:

  • RESULT: FAILURE :x:
  • URL: https://build.ci.opensearch.org/job/gradle-check/2550/
  • CommitID: ac07516ae2c2513aa5d0bdc663a5fd0e1a8c6f41

github-actions[bot] avatar Sep 02 '22 15:09 github-actions[bot]

Gradle Check (Jenkins) Run Completed with:

  • RESULT: FAILURE :x:
  • URL: https://build.ci.opensearch.org/job/gradle-check/2552/
  • CommitID: 13b5f4cbbdcbc7bc82ca2bf1a176b8cdf5cf589c

github-actions[bot] avatar Sep 02 '22 16:09 github-actions[bot]

Gradle Check (Jenkins) Run Completed with:

  • RESULT: FAILURE :x:
  • URL: https://build.ci.opensearch.org/job/gradle-check/2643/
  • CommitID: 660b3d563fdc67062e3009ab5bc27a6ce4172244

github-actions[bot] avatar Sep 05 '22 07:09 github-actions[bot]

Gradle Check (Jenkins) Run Completed with:

  • RESULT: UNSTABLE :x:
  • URL: https://build.ci.opensearch.org/job/gradle-check/2644/
  • CommitID: 2f65bf6beaf4a62e542ff42bebd593b085e8e410

github-actions[bot] avatar Sep 05 '22 08:09 github-actions[bot]

Gradle Check (Jenkins) Run Completed with:

  • RESULT: UNSTABLE :x:
  • URL: https://build.ci.opensearch.org/job/gradle-check/2647/
  • CommitID: c0b7898c79b9209636ed7e3ab787c9b2ee4c43f4

github-actions[bot] avatar Sep 05 '22 10:09 github-actions[bot]

Gradle Check (Jenkins) Run Completed with:

  • RESULT: FAILURE :x:
  • URL: https://build.ci.opensearch.org/job/gradle-check/2654/
  • CommitID: bf4c52d3953e509924df3881bbb0cec106cdb937

github-actions[bot] avatar Sep 05 '22 14:09 github-actions[bot]

Gradle Check (Jenkins) Run Completed with:

  • RESULT: FAILURE :x:
  • URL: https://build.ci.opensearch.org/job/gradle-check/2690/
  • CommitID: 7fbb70e122f45c1ce8ed8d4ca3a7a261762983e1

github-actions[bot] avatar Sep 06 '22 12:09 github-actions[bot]

Gradle Check (Jenkins) Run Completed with:

  • RESULT: FAILURE :x:
  • URL: https://build.ci.opensearch.org/job/gradle-check/2700/
  • CommitID: b7feabf4389db44b309c72b2437cfbae0d9ba6b2

github-actions[bot] avatar Sep 06 '22 13:09 github-actions[bot]

Gradle Check (Jenkins) Run Completed with:

  • RESULT: FAILURE :x:
  • URL: https://build.ci.opensearch.org/job/gradle-check/2703/
  • CommitID: db96adf9921cddde121e71c2b32a83f844e510c5

github-actions[bot] avatar Sep 06 '22 14:09 github-actions[bot]

Gradle Check (Jenkins) Run Completed with:

  • RESULT: FAILURE :x:
  • URL: https://build.ci.opensearch.org/job/gradle-check/2705/
  • CommitID: 5fdf0a57e839223ece7d30f79360437b64c13e7b

github-actions[bot] avatar Sep 06 '22 14:09 github-actions[bot]

Gradle Check (Jenkins) Run Completed with:

  • RESULT: FAILURE :x:
  • URL: https://build.ci.opensearch.org/job/gradle-check/2706/
  • CommitID: c501f19ac38c9a36b5b5356114e2dde9e20958df

github-actions[bot] avatar Sep 06 '22 14:09 github-actions[bot]

@reta @Bukhtawar please review this PR. This PR is planned for 2.3

bharath-techie avatar Sep 06 '22 15:09 bharath-techie

Gradle Check (Jenkins) Run Completed with:

  • RESULT: FAILURE :x:
  • URL: https://build.ci.opensearch.org/job/gradle-check/2710/
  • CommitID: 85b89fd582e4d98708ec0eabb9f48e0209f1f2e5

github-actions[bot] avatar Sep 06 '22 15:09 github-actions[bot]

Gradle Check (Jenkins) Run Completed with:

  • RESULT: FAILURE :x:
  • URL: https://build.ci.opensearch.org/job/gradle-check/2709/
  • CommitID: cc67e750b76efcc742bb332c2b737dc51b1f203f

github-actions[bot] avatar Sep 06 '22 15:09 github-actions[bot]

Gradle Check (Jenkins) Run Completed with:

  • RESULT: FAILURE :x:
  • URL: https://build.ci.opensearch.org/job/gradle-check/2712/
  • CommitID: 46f9382082a74e0130712d2310eac969e0c7c085

github-actions[bot] avatar Sep 06 '22 15:09 github-actions[bot]

Gradle Check (Jenkins) Run Completed with:

  • RESULT: FAILURE :x:
  • URL: https://build.ci.opensearch.org/job/gradle-check/2718/
  • CommitID: a0199e8a03a773f0881185137e4d9da68690ccc7

github-actions[bot] avatar Sep 06 '22 16:09 github-actions[bot]

Gradle Check (Jenkins) Run Completed with:

  • RESULT: SUCCESS :white_check_mark:
  • URL: https://build.ci.opensearch.org/job/gradle-check/2730/
  • CommitID: 090ccffbf1cf20de7cfb2ccd6ff1907df6dcbe4f

github-actions[bot] avatar Sep 06 '22 17:09 github-actions[bot]

Codecov Report

Merging #4388 (2898976) into main (7ebb2af) will decrease coverage by 0.03%. The diff coverage is 41.00%.

@@             Coverage Diff              @@
##               main    #4388      +/-   ##
============================================
- Coverage     70.68%   70.65%   -0.04%     
- Complexity    57379    57526     +147     
============================================
  Files          4628     4635       +7     
  Lines        276073   276645     +572     
  Branches      40421    40489      +68     
============================================
+ Hits         195146   195463     +317     
- Misses        64562    64803     +241     
- Partials      16365    16379      +14     
Impacted Files Coverage Δ
.../java/org/opensearch/client/RequestConverters.java 84.02% <0.00%> (-1.65%) :arrow_down:
...ava/org/opensearch/client/RestHighLevelClient.java 41.75% <0.00%> (-0.66%) :arrow_down:
...ion/admin/indices/segments/PitSegmentsRequest.java 45.45% <0.00%> (-23.78%) :arrow_down:
...pensearch/action/search/GetAllPitNodesRequest.java 33.33% <ø> (ø)
...org/opensearch/action/search/GetAllPitsAction.java 100.00% <ø> (ø)
...er/src/main/java/org/opensearch/client/Client.java 40.00% <ø> (ø)
.../org/opensearch/client/support/AbstractClient.java 34.76% <0.00%> (+0.33%) :arrow_up:
...org/opensearch/common/logging/LogConfigurator.java 24.63% <0.00%> (+6.35%) :arrow_up:
...search/rest/action/search/RestDeletePitAction.java 100.00% <ø> (ø)
.../opensearch/action/search/CreatePitController.java 74.60% <7.69%> (-7.70%) :arrow_down:
... and 499 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

codecov-commenter avatar Sep 06 '22 17:09 codecov-commenter

Gradle Check (Jenkins) Run Completed with:

  • RESULT: SUCCESS :white_check_mark:
  • URL: https://build.ci.opensearch.org/job/gradle-check/3210/
  • CommitID: 8871f4e812d099126b6c9925f36ab261a9de1294

github-actions[bot] avatar Sep 19 '22 15:09 github-actions[bot]

Gradle Check (Jenkins) Run Completed with:

  • RESULT: SUCCESS :white_check_mark:
  • URL: https://build.ci.opensearch.org/job/gradle-check/3211/
  • CommitID: 823b96a68f5ca878100bbc4ad3a6f15b82579e76

github-actions[bot] avatar Sep 19 '22 15:09 github-actions[bot]

Looks like we are getting there, thanks @bharath-techie !

reta avatar Sep 19 '22 18:09 reta

@reta @Bukhtawar please review the latest changes - this is the security model to refer to : https://github.com/opensearch-project/security/issues/2087#issuecomment-1247972936

bharath-techie avatar Sep 20 '22 14:09 bharath-techie

Gradle Check (Jenkins) Run Completed with:

  • RESULT: FAILURE :x:
  • URL: https://build.ci.opensearch.org/job/gradle-check/3250/
  • CommitID: 98abc1d419f961c5259b22598bc5162c83d81c92

github-actions[bot] avatar Sep 20 '22 14:09 github-actions[bot]

Gradle Check (Jenkins) Run Completed with:

  • RESULT: SUCCESS :white_check_mark:
  • URL: https://build.ci.opensearch.org/job/gradle-check/3252/
  • CommitID: 565592524d2e2d9a2dab931763c556cba510d3f5

github-actions[bot] avatar Sep 20 '22 15:09 github-actions[bot]

Gradle Check (Jenkins) Run Completed with:

  • RESULT: FAILURE :x:
  • URL: https://build.ci.opensearch.org/job/gradle-check/3254/
  • CommitID: 9ffef7323c2864b68a014166f193f9d937f36dae

github-actions[bot] avatar Sep 20 '22 15:09 github-actions[bot]