OpenSearch icon indicating copy to clipboard operation
OpenSearch copied to clipboard

REST API Layer changes for recommission support

Open pranikum opened this issue 3 years ago • 11 comments

Signed-off-by: pranikum [email protected]

Description

This change contain REST API layer changes for Recommission API support. This pr is dependent of Service layer changes. (https://github.com/opensearch-project/OpenSearch/pull/4320)

This change has some changes for the PR https://github.com/opensearch-project/OpenSearch/pull/4084

Issues Resolved

[List any issues this PR will resolve]

Check List

  • [x] New functionality includes testing.
    • [x] All tests pass
  • [ ] New functionality has been documented.
    • [ ] New functionality has javadoc added
  • [x] Commits are signed per the DCO using --signoff
  • [x] Commit changes are listed out in CHANGELOG.md file (See: Changelog)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. For more information on following Developer Certificate of Origin and signing off your commits, please check here.

pranikum avatar Aug 29 '22 14:08 pranikum

Gradle Check (Jenkins) Run Completed with:

  • RESULT: FAILURE :x:
  • URL: https://build.ci.opensearch.org/job/gradle-check/2191/
  • CommitID: 84a8d4427383e0c384aad5c28f70d16ccc4dd6db

github-actions[bot] avatar Aug 29 '22 14:08 github-actions[bot]

Gradle Check (Jenkins) Run Completed with:

  • RESULT: FAILURE :x:
  • URL: https://build.ci.opensearch.org/job/gradle-check/2424/
  • CommitID: 73c55bc6b78a8934435461382163337ae1a7ce9d

github-actions[bot] avatar Sep 01 '22 12:09 github-actions[bot]

Changes to -

  1. client/rest-high-level/src/test/java/org/opensearch/client/RestHighLevelClientTests.java
  2. rest-api-spec/src/main/resources/rest-api-spec/api are missing. We need to add that

imRishN avatar Sep 02 '22 08:09 imRishN

Gradle Check (Jenkins) Run Completed with:

  • RESULT: FAILURE :x:
  • URL: https://build.ci.opensearch.org/job/gradle-check/2797/
  • CommitID: 88ed4866409979d17dddbde1baefebe5ebb425b2

github-actions[bot] avatar Sep 07 '22 05:09 github-actions[bot]

Gradle Check (Jenkins) Run Completed with:

  • RESULT: FAILURE :x:
  • URL: https://build.ci.opensearch.org/job/gradle-check/2799/
  • CommitID: b60379f023b18f1e1df2f4b34eab67c2540b49bb

github-actions[bot] avatar Sep 07 '22 05:09 github-actions[bot]

Gradle Check (Jenkins) Run Completed with:

  • RESULT: FAILURE :x:
  • URL: https://build.ci.opensearch.org/job/gradle-check/2800/
  • CommitID: 02a3d305c8b455600f993a631e504154ebd4cda0

github-actions[bot] avatar Sep 07 '22 05:09 github-actions[bot]

Gradle Check (Jenkins) Run Completed with:

  • RESULT: FAILURE :x:
  • URL: https://build.ci.opensearch.org/job/gradle-check/3248/
  • CommitID: 20aab7c2cbde2ec259e3922f89c2e2503666586c

github-actions[bot] avatar Sep 20 '22 14:09 github-actions[bot]

Gradle Check (Jenkins) Run Completed with:

  • RESULT: FAILURE :x:
  • URL: https://build.ci.opensearch.org/job/gradle-check/3256/
  • CommitID: 6abea15701faed3b8406ac8fbc45ffedd74d691f

github-actions[bot] avatar Sep 20 '22 15:09 github-actions[bot]

Gradle Check (Jenkins) Run Completed with:

  • RESULT: FAILURE :x:
  • URL: https://build.ci.opensearch.org/job/gradle-check/3263/
  • CommitID: c70f990484d21e51059d91c07c309dd1970f0d7e

github-actions[bot] avatar Sep 20 '22 16:09 github-actions[bot]

Gradle Check (Jenkins) Run Completed with:

  • RESULT: SUCCESS :white_check_mark:
  • URL: https://build.ci.opensearch.org/job/gradle-check/3266/
  • CommitID: 89eff69b63c23ec7ea1809c4d05b4013f58040fe

github-actions[bot] avatar Sep 20 '22 16:09 github-actions[bot]

Codecov Report

Merging #4321 (7312b41) into main (57a4aed) will decrease coverage by 0.17%. The diff coverage is 65.24%.

@@             Coverage Diff              @@
##               main    #4321      +/-   ##
============================================
- Coverage     70.81%   70.64%   -0.18%     
+ Complexity    57438    57426      -12     
============================================
  Files          4617     4634      +17     
  Lines        275545   276114     +569     
  Branches      40340    40421      +81     
============================================
- Hits         195125   195050      -75     
- Misses        64085    64743     +658     
+ Partials      16335    16321      -14     
Impacted Files Coverage Δ
...va/org/opensearch/geometry/GeometryCollection.java 96.42% <0.00%> (+0.13%) :arrow_up:
...le/customsettings/ExampleCustomSettingsConfig.java 29.03% <ø> (ø)
...le/customsettings/ExampleCustomSettingsPlugin.java 9.09% <ø> (ø)
...igheuristic/CustomSignificanceHeuristicPlugin.java 0.00% <0.00%> (ø)
...ch/example/customsigheuristic/SimpleHeuristic.java 86.66% <ø> (ø)
...earch/example/customsuggester/CustomSuggester.java 0.00% <0.00%> (ø)
...example/customsuggester/CustomSuggesterPlugin.java 0.00% <0.00%> (ø)
...arch/example/customsuggester/CustomSuggestion.java 0.00% <ø> (ø)
...ample/customsuggester/CustomSuggestionBuilder.java 0.00% <ø> (ø)
...ample/customsuggester/CustomSuggestionContext.java 0.00% <ø> (ø)
... and 541 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

codecov-commenter avatar Sep 20 '22 17:09 codecov-commenter

Gradle Check (Jenkins) Run Completed with:

  • RESULT: SUCCESS :white_check_mark:
  • URL: https://build.ci.opensearch.org/job/gradle-check/3313/
  • CommitID: 86f8c54550cd8483666e62edada5787d3babbdba

github-actions[bot] avatar Sep 22 '22 12:09 github-actions[bot]

Gradle Check (Jenkins) Run Completed with:

  • RESULT: FAILURE :x:
  • URL: https://build.ci.opensearch.org/job/gradle-check/3314/
  • CommitID: 24ab026d76fd60491da077da2ae05dc7df93f7a2

github-actions[bot] avatar Sep 22 '22 12:09 github-actions[bot]

Gradle Check (Jenkins) Run Completed with:

  • RESULT: FAILURE :x:
  • URL: https://build.ci.opensearch.org/job/gradle-check/3315/
  • CommitID: 3bcda1af71eaf4cfe005d40115cdb0d2b992bfa6

github-actions[bot] avatar Sep 22 '22 12:09 github-actions[bot]

Gradle Check (Jenkins) Run Completed with:

  • RESULT: SUCCESS :white_check_mark:
  • URL: https://build.ci.opensearch.org/job/gradle-check/3318/
  • CommitID: 7312b4179c28c769c327cac1b78ec1290a685f32

github-actions[bot] avatar Sep 22 '22 13:09 github-actions[bot]

Closing this PR. Reopened another one.

https://github.com/opensearch-project/OpenSearch/pull/4604

pranikum avatar Sep 27 '22 09:09 pranikum