OpenSearch icon indicating copy to clipboard operation
OpenSearch copied to clipboard

[Segment Replication] Fix OngoingSegmentReplications to key by allocation ID instead of DiscoveryNode.

Open mch2 opened this issue 3 years ago • 4 comments

Signed-off-by: Marc Handalian [email protected]

Description

This change fixes segrep to work with multiple shards per node by keying ongoing replications on allocation ID. This also updates cancel methods to ensure state is properly cleared on shard cancel.

Issues Resolved

#4129.

Check List

  • [x] New functionality includes testing.
    • [x] All tests pass
  • [ ] New functionality has been documented.
    • [ ] New functionality has javadoc added
  • [x] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. For more information on following Developer Certificate of Origin and signing off your commits, please check here.

mch2 avatar Aug 10 '22 03:08 mch2

Gradle Check (Jenkins) Run Completed with:

  • RESULT: UNSTABLE :x:
  • URL: https://build.ci.opensearch.org/job/gradle-check/1644/
  • CommitID: c95112f2c471c5e2e77ba01c90442da74425a5b0

github-actions[bot] avatar Aug 10 '22 03:08 github-actions[bot]

Gradle Check (Jenkins) Run Completed with:

  • RESULT: FAILURE :x:
  • URL: https://build.ci.opensearch.org/job/gradle-check/1645/
  • CommitID: 3092e172ae1728f84e036d647c3b71538e33304b

github-actions[bot] avatar Aug 10 '22 04:08 github-actions[bot]

@mch2 1645 is failing with spotlessCheck.

dreamer-89 avatar Aug 10 '22 04:08 dreamer-89

Gradle Check (Jenkins) Run Completed with:

  • RESULT: SUCCESS :white_check_mark:
  • URL: https://build.ci.opensearch.org/job/gradle-check/1646/
  • CommitID: 6548f9b9614160cb1f193f9724d066913098dc6f

github-actions[bot] avatar Aug 10 '22 04:08 github-actions[bot]