OpenSearch icon indicating copy to clipboard operation
OpenSearch copied to clipboard

Adding documentation about creation of uber-JARs

Open pgtgrly opened this issue 1 year ago • 8 comments

Signed-off-by: Pranav Garg [email protected]

Description

Adding documentation about creation of uber-JARs

Issues Resolved

https://github.com/opensearch-project/OpenSearch/issues/3702

Check List

  • [x] New functionality includes testing.
    • [x] All tests pass
  • [x] New functionality has been documented.
    • [x] New functionality has javadoc added
  • [x] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. For more information on following Developer Certificate of Origin and signing off your commits, please check here.

pgtgrly avatar Jul 06 '22 05:07 pgtgrly

Gradle Check (Jenkins) Run Completed with:

  • RESULT: FAILURE :x:
  • URL: https://build.ci.opensearch.org/job/gradle-check/164/
  • CommitID: 3f42e82defc3263d798d087c7da5b5279d5201d3

github-actions[bot] avatar Jul 06 '22 06:07 github-actions[bot]

Gradle Check (Jenkins) Run Completed with:

  • RESULT: FAILURE :x:
  • URL: https://build.ci.opensearch.org/job/gradle-check/168/
  • CommitID: 545def7fe5a73ec714cfeeb965bd323e8a5344f6

github-actions[bot] avatar Jul 06 '22 07:07 github-actions[bot]

Gradle Check (Jenkins) Run Completed with:

  • RESULT: FAILURE :x:
  • URL: https://build.ci.opensearch.org/job/gradle-check/169/
  • CommitID: 10f4309b977f5a4f5baa213213d849425e3f844b

github-actions[bot] avatar Jul 06 '22 08:07 github-actions[bot]

Gradle Check (Jenkins) Run Completed with:

  • RESULT: FAILURE :x:
  • URL: https://build.ci.opensearch.org/job/gradle-check/675/
  • CommitID: ea0e54895c85004ffd0863cbac4a9f12891cfc1f

github-actions[bot] avatar Jul 15 '22 06:07 github-actions[bot]

Gradle Check (Jenkins) Run Completed with:

  • RESULT: FAILURE :x:
  • URL: https://build.ci.opensearch.org/job/gradle-check/1158/
  • CommitID: 062ad7f3ef6b1aad2eea1ec7e42c80a4b735163d

github-actions[bot] avatar Aug 01 '22 05:08 github-actions[bot]

Gradle Check (Jenkins) Run Completed with:

  • RESULT: FAILURE :x:
  • URL: https://build.ci.opensearch.org/job/gradle-check/1157/
  • CommitID: ee5072d40e123dfc06e52a09a9c8c24f1474b670

github-actions[bot] avatar Aug 01 '22 05:08 github-actions[bot]

Gradle Check (Jenkins) Run Completed with:

  • RESULT: FAILURE :x:
  • URL: https://build.ci.opensearch.org/job/gradle-check/1562/
  • CommitID: 2d2d6479ae74fd587a1386350fc3021df92293a8

github-actions[bot] avatar Aug 08 '22 13:08 github-actions[bot]

I have some more nitpicks, the only must have is the capitalization of the section title. Also what's up with CI/CD? :(

The jenkins link mentions that there were no ownership configured for the test run, Can that be the issue? All the tests are skipped in the run.

pgtgrly avatar Aug 10 '22 07:08 pgtgrly

Why are PRs getting merged before passing gradle check?

nknize avatar Aug 16 '22 01:08 nknize

Why are PRs getting merged before passing gradle check?

It was a markdown only change (docs). I didn't want the doc to be incorrect regardless of the status of our build.

dblock avatar Aug 16 '22 16:08 dblock