OpenSearch icon indicating copy to clipboard operation
OpenSearch copied to clipboard

Add ppc64le architecture

Open helix-loop opened this issue 3 years ago • 7 comments

Add ppc64le architecture for the current architecture check.

Description

Ability to build OpenSearch on ppc64le architecture

Issues Resolved

https://github.com/opensearch-project/OpenSearch/issues/1303

Check List

  • [ ] New functionality includes testing.
    • [ ] All tests pass
  • [ ] New functionality has been documented.
    • [ ] New functionality has javadoc added
  • [x] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. For more information on following Developer Certificate of Origin and signing off your commits, please check here.

helix-loop avatar May 24 '22 21:05 helix-loop

:white_check_mark:   Gradle Check success 61cff75e69b9aa11786beaafd52df8e74a057643 Log 5569

Reports 5569

opensearch-ci-bot avatar May 24 '22 21:05 opensearch-ci-bot

@helix-loop Thanks! The PR needs git commit --amend -s to get DCO to pass.

In the meantime, do we need both ppc64 and ppc64le? And what hardware did you test this on?

dblock avatar May 24 '22 23:05 dblock

@dblock It would be better to have both, but I can only test and tested this on ppc64le.

helix-loop avatar May 27 '22 22:05 helix-loop

:white_check_mark:   Gradle Check success dcfb53aa7a6f87667063d5247cdbea80f5f99754 Log 5642

Reports 5642

opensearch-ci-bot avatar May 27 '22 23:05 opensearch-ci-bot

Is this ready? Unit tests?

dblock avatar Jun 13 '22 23:06 dblock

@helix-loop are you still working on this? What is left to get this from draft to ready-to-merge?

kartg avatar Aug 04 '22 00:08 kartg

Currently not. I guess the Unit tests are missing to get this ready. However https://github.com/opensearch-project/OpenSearch/pull/3930 seems to be further.

helix-loop avatar Aug 04 '22 19:08 helix-loop

@helix-loop : Are you still working on this ?

dreamer-89 avatar Mar 27 '23 16:03 dreamer-89

@helix-loop Thank you for your contribution! I'm afraid that I have to close this PR. As mentioned in issue #1303, the code change is made by commit https://github.com/opensearch-project/OpenSearch/commit/d76adf3504e3001a84d53177af8ea36af2cc65c1

tlfeng avatar Apr 05 '23 02:04 tlfeng